Repository navigation
Conversation
Replace the local ObjectiveFunctionAttribute wrapper and its bridge optimizer get/set implementations with MOI.Bridges.ObjectiveFunctionAttribute. Retain the attribute-specific bridge transformations and add a regression test for forwarding through a slack child that is itself bridged. This companion sketch is based directly on DiffOpt master and depends on the additive MOI API in bl/objective-function-attribute. Its minimum MOI compatibility must be updated once that API has a release version, before merging this migration. Validation: test/bridges.jl passes all 26 assertions with normal compilation, including allocation checks. The trivial-QP test passes all 64 assertions through forward and reverse differentiation. JuliaFormatter 2 applied to the repository.
1 of 3 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the local ObjectiveFunctionAttribute wrapper and its bridge optimizer get/set implementations with MOI.Bridges.ObjectiveFunctionAttribute. Retain the attribute-specific bridge transformations and add a regression test for forwarding through a slack child that is itself bridged.
Merging this allows jump-dev/MathOptInterface.jl#3130 to be non-breaking.