Repository navigation
[Automated] Draft docs (kagent): [Helm] Use full DNS name for kagent tools MCP server - #659
Closed
github-actions[bot] wants to merge 1 commit into
Closed
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…tools MCP server Signed-off-by: GitHub Action <action@github.com>
Contributor
|
Folded into #672. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kagent-dev/kagent#3334 — [Helm] Use full DNS name for kagent tools MCP server
Docs versions:
1.x(first shipped in v1.0.0-rc1)What changes for users: On clusters that use a DNS domain other than
cluster.local, the kagent chart builds the bundledkagent-tool-serverRemoteMCPServer URL with.svc.<global.clusterDomain>. Setglobal.clusterDomainduring install so agents can reach built-in tools through the cluster's DNS suffix.What the docs now say: The Install kagent page now shows when to set
global.clusterDomainin the values file thatkagent installpasses to the chart, and names the generatedkagent-tool-serverURL as the reason.Not verified: No cluster; the configuration is unrun.
How
kagent-3334was drafted, and what was not verifiedPlan, and what changed it
global.clusterDomainto one of the code-path candidate pages.installation.mdowns the values file that reacheskagent install;operational-considerations.mdis production tuning and does not own initial chart defaults.docs-site/content/kagent/1.x/setup/installation.md.Why a documentation change is necessary
The pull request changes the generated
kagent-tool-serverRemoteMCPServer URL fromhttp://<service>.<namespace>:8084/mcptohttp://<service>.<namespace>.svc.<global.clusterDomain>:8084/mcp. The generated Helm reference already listsglobal.clusterDomain, but it is regenerated and cannot carry the usage guidance. The installation guide already creates the values file that feeds the kagent chart, so it is the page where a reader needs to learn when to set the field.What changed on disk
docs-site/content/kagent/1.x/setup/installation.md — Added the optional
global.clusterDomainvalues snippet for clusters with a non-default DNS domain.How to verify this change
kubectl get remotemcpserver kagent-tool-server -n kagent -o jsonpath='{.spec.url}'.svc.corp.example:8084/mcp.kubectl get remotemcpserver kagent-tool-server -n kagent -o jsonpath='{.status.conditions[?(@.type=="Accepted")].status}'True.Proposed release note
No
proposed-release-note.md:markers.notes_placeableis false for this product. Suggested text: The kagent chart now usesglobal.clusterDomainwhen it creates the bundledkagent-tool-serverRemoteMCPServer URL, so clusters with a DNS domain other thancluster.localcan install kagent with the correct in-cluster service address.What was not verified
How the pages were chosen (triage report)
Feature clusters
Kept apart on purpose. Merging wrongly produces a guide that documents two things and explains neither, so these are reported for a person to merge rather than grouped automatically:
docs-site/content/kagent/1.x/setup/installation.mdas a candidate, but for one of them it is one page among more than 3, so they are kept apart; merge them if both drafts do land thereNew configuration: no page mentions it yet
kagent-dev/kagent#3334 — [Helm] Use full DNS name for kagent tools MCP server
kagent-dev/websiteDraft branch:
pr-tracker-draft-kagent-3334