Repository navigation
[Automated] Draft docs (kagent): Add a helm configuration option for SandboxConfig ref - #661
Closed
github-actions[bot] wants to merge 1 commit into
Closed
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…SandboxConfig ref Signed-off-by: GitHub Action <action@github.com>
Contributor
|
Covered by #652 (v1.0.0-rc1 docs update). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kagent-dev/kagent#3357 — Add a helm configuration option for SandboxConfig ref
Docs versions:
1.x(first shipped in v1.0.0-rc1)What changes for users: Operators can set
substrateWorkerPool.sandboxConfigRefto name a custom SandboxConfig for the selected WorkerPool sandbox class. If they omit the value or leave it empty, the chart still usesgvisor-defaultforgvisorandmicrovmformicrovm.What the docs now say: The Tune Agent Substrate guide now shows the optional Helm value beside
sandboxClassandworkerImage. The Sandboxing concept page now scopes the built-in SandboxConfig names to the default behavior.Not verified: No cluster was configured; the configuration and commands are unrun, and internal links are unchecked.
How
kagent-3357was drafted, and what was not verifiedPlan, and what changed it
substrateWorkerPool.sandboxConfigRefto the WorkerPool sandbox-class guidance inoperations/tune-agent-substrate.md.about/substrate-runtime/sandboxing.mdalso stated the built-in SandboxConfig names unconditionally.Why a documentation change is necessary
The pull request adds
substrateWorkerPool.sandboxConfigRefto the kagent Helm values and uses that value as the WorkerPool SandboxConfig reference when it is set. The Tune Agent Substrate guide already tells readers how to setsubstrateWorkerPool.sandboxClassand how to confirm the required SandboxConfig, so a reader with custom runtime asset URLs would not know that the chart can point at a custom SandboxConfig. The sandboxing concept page also said thatgvisorandmicrovmtemplates always name the built-in SandboxConfig resources, which is no longer true when the new value is set.What changed on disk
docs-site/content/kagent/1.x/operations/tune-agent-substrate.md: Adds the optionalsandboxConfigRefHelm value, its default behavior, and the corresponding SandboxConfig check.docs-site/content/kagent/1.x/about/substrate-runtime/sandboxing.md: Updates the SandboxConfig naming note so the built-in names are described as defaults.How to verify this change
Confirm that the custom SandboxConfig exists and serves the selected class.
kubectl get sandboxconfig custom-gvisor-config -o jsonpath='{.spec.sandboxClass}'The command shows
gvisor.Upgrade kagent with a values file that sets the custom reference.
Check the rendered WorkerPool.
kubectl get workerpool kagent-default -n kagent -o jsonpath='{.spec.sandboxClasses[0].configRef.name}'The command shows
custom-gvisor-config.Proposed release note
No
proposed-release-note.md:markers.notes_placeableis false for this product. Suggested text: The kagent Helm chart now acceptssubstrateWorkerPool.sandboxConfigRef, so operators can point a WorkerPool at a custom SandboxConfig for the selected sandbox class. Omit the value to keepgvisor-defaultforgvisorandmicrovmformicrovm.What was not verified
How the pages were chosen (triage report)
Feature clusters
Kept apart on purpose. Merging wrongly produces a guide that documents two things and explains neither, so these are reported for a person to merge rather than grouped automatically:
docs-site/content/kagent/1.x/setup/installation.mdas a candidate, but for one of them it is one page among more than 3, so they are kept apart; merge them if both drafts do land thereDraft a documentation change
kagent-dev/kagent#3357 — Add a helm configuration option for SandboxConfig ref
kagent-dev/websitesandboxConfigReffield undersubstrateWorkerPoolin the helm chart to allows overriding the default behavior if set.Draft branch:
pr-tracker-draft-kagent-3357