Repository navigation
[Automated] Draft docs (kagent): fix(a2a): deliver push notifications concurrently - #662
Open
github-actions[bot] wants to merge 1 commit into
Open
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
… concurrently Signed-off-by: GitHub Action <action@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kagent-dev/kagent#3366 — fix(a2a): deliver push notifications concurrently
Docs versions:
1.x(first shipped in v1.0.0-rc1)No code-path rule covers 6 touched file(s). The planner could route these only by identifier search, so the candidate pages may miss what they changed, including in the other mode:
docs/architecture/a2a-push-notifications.mdgo/api/gen/kagent/config/v1/config.pb.gogo/core/internal/service/session/push_notifications.gogo/core/pkg/app/app.gogo/core/pkg/config/defaults.goproto/kagent/config/v1/config.protoWhat changes for users: Operators can tune A2A task callback delivery with
config.push.maxConcurrencyandconfig.push.sendTimeout. Each controller replica now sends callbacks concurrently by default, up to 10 in-flight deliveries, and each callback attempt defaults to a 5-second timeout.What the docs now say: The Operational considerations page now explains how to tune push notification delivery, what the two Helm values do, the per-replica concurrency math, and how to roll the values into the kagent controller.
Not verified: The configuration was not applied to a cluster, and internal links are unchecked.
How
kagent-3366was drafted, and what was not verifiedPlan, and what changed it
operations/operational-considerations.mdalready owns controller configuration, controller replicas, and push notification signing;setup/installation.mdis for first install steps, andoperations/upgrade-from-0x.mdis for migration from 0.x.Tune push notification deliverysection tooperations/operational-considerations.md.Why a documentation change is necessary
The pull request adds
config.push.maxConcurrencyandconfig.push.sendTimeoutto the kagent Helm values and wires them into the controller's push worker. The generated Helm reference covers the raw values, but the existing candidate pages did not explain when to tune callback delivery or how the per-replica concurrency limit changes capacity. I choseoperations/operational-considerations.mdbecause it already documents production controller configuration, theconfigHelm block, controller replicas, and push notification signing. I rejectedsetup/installation.mdbecause first-time installation does not own production tuning, and I rejectedoperations/upgrade-from-0x.mdbecause the change is not specific to migrating from 0.x.What changed on disk
docs-site/content/kagent/1.x/operations/operational-considerations.md— Added an anchored section with a Helm values example, field descriptions forconfig.push.maxConcurrencyandconfig.push.sendTimeout, the effective concurrency calculation, and the upgrade and rollout commands.How to verify this change
config.push.maxConcurrencyandconfig.push.sendTimeoutvalues tokagent.yaml, and upgrade the Helm release:20and10s.Proposed release note
No
proposed-release-note.md:markers.notes_placeableis false. Suggested note text for a reviewer who needs it: kagent now delivers A2A task callbacks concurrently per controller replica. Tune callback delivery withconfig.push.maxConcurrencyandconfig.push.sendTimeout; the defaults are 10 in-flight callback attempts per replica and a 5-second timeout.What was not verified
The configuration was not applied to a cluster, so every command in this diff is unrun. The workflow-provided
cluster-facts.mdis an API surface only and does not mean that anything was applied. Internal links are unchecked because Hugo was not run.How the pages were chosen (triage report)
Feature clusters
Kept apart on purpose. Merging wrongly produces a guide that documents two things and explains neither, so these are reported for a person to merge rather than grouped automatically:
docs-site/content/kagent/1.x/setup/installation.mdas a candidate, but for one of them it is one page among more than 3, so they are kept apart; merge them if both drafts do land thereNew configuration: no page mentions it yet
kagent-dev/kagent#3366 — fix(a2a): deliver push notifications concurrently
kagent-dev/websiteconfig.push.maxConcurrencyandconfig.push.sendTimeoutin Helm, defaulting to 10 in-flight deliveries and 5 seconds.docs/architecture/a2a-push-notifications.mdgo/api/gen/kagent/config/v1/config.pb.gogo/core/internal/service/session/push_notifications.gogo/core/pkg/app/app.gogo/core/pkg/config/defaults.goproto/kagent/config/v1/config.protoDraft branch:
pr-tracker-draft-kagent-3366