Repository navigation
[Automated] Draft docs (kagent): fix: include image pull secrets in substrate worker pool service account - #664
Closed
github-actions[bot] wants to merge 1 commit into
Closed
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…ubstrate worker pool service account Signed-off-by: GitHub Action <action@github.com>
Contributor
|
Closing as folded into #652. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kagent-dev/kagent#3443 — fix: include image pull secrets in substrate worker pool service account
Docs versions:
1.x(first shipped in v1.0.0-rc1)What changes for users: A chart-created Worker ServiceAccount now receives
imagePullSecretsandglobal.imagePullSecrets, so Worker pods that usesubstrateWorkerPool.workerImagecan pull from private or mirrored registries through the ServiceAccount. The chart merges duplicate Secret names, and an externally managed Worker ServiceAccount is unchanged.What the docs now say: The Tune Agent Substrate page now explains how
imagePullSecretsandglobal.imagePullSecretsapply to the Worker ServiceAccount, and warns readers to add pull secrets themselves whensubstrateWorkerPool.serviceAccount.createisfalse.Not verified: No cluster API, Helm, or Hugo command was run in this sandbox; the configuration is unrun and internal links are unchecked.
How
kagent-3443was drafted, and what was not verifiedPlan, and what changed it
substrateWorkerPool.serviceAccount.docs-site/content/kagent/1.x/operations/tune-agent-substrate.md.Why a documentation change is necessary
The pull request adds the chart's
imagePullSecretshelper to the Worker ServiceAccount template. The Tune Agent Substrate page already explains how the chart creates or references that ServiceAccount, but did not say how image pull secrets reach Workers or what happens when the ServiceAccount is external. A reader who mirrors the Worker image or uses a private registry needs to know whether to set chart values or update the external ServiceAccount.What changed on disk
docs-site/content/kagent/1.x/operations/tune-agent-substrate.md— Added the image pull secret behavior to the Worker ServiceAccount section.How to verify this change
selected-poolshowsimagePullSecretswithname: mirror-auth.local-auth,shared-auth, andmirror-authonce each.--set substrateWorkerPool.serviceAccount.create=false. The Worker ServiceAccount template renders no document, because the chart does not update the external ServiceAccount.Proposed release note
Fixes the kagent Helm chart so a chart-created Agent Substrate Worker ServiceAccount receives chart-level and global image pull secrets. If you manage the Worker ServiceAccount outside the chart, add the pull secrets to that account.
What was not verified
cluster-facts.mdwas used only as an API surface; nothing was applied to the provisioned cluster.How the pages were chosen (triage report)
Draft a documentation change
kagent-dev/kagent#3443 — fix: include image pull secrets in substrate worker pool service account
kagent-dev/websitekagent.imagePullSecretsin thesubstrateWorkerPoolservice accountDraft branch:
pr-tracker-draft-kagent-3443