Repository navigation
[Automated] Draft docs (kagent): feat(auth): support human and machine principals (+1 related) - #665
Closed
github-actions[bot] wants to merge 1 commit into
Closed
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…e principals (+1 related) Signed-off-by: GitHub Action <action@github.com>
Contributor
|
Folded into #672. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[kagent-dev/kagent#3358 + kagent-dev/kagent#3409](kagent-dev/kagent#3358 and kagent-dev/kagent#3409) — feat(auth): support human and machine principals; remove public suspend and resume controls
Docs versions:
1.x(first shipped in v1.0.0-rc1)No code-path rule covers 23 touched file(s). The planner could route these only by identifier search, so the candidate pages may miss what they changed, including in the other mode:
docs/architecture/a2a-gateway.mddocs/architecture/oidc-proxy-authentication.mdgo/api/gen/kagent/config/v1/config.pb.gogo/core/internal/grpcserver/interceptors.gogo/core/internal/httpserver/auth/authn.gogo/core/internal/httpserver/auth/proxy_authn.goWhat changes for users: Machine callers can authenticate to the kagent API with Kubernetes ServiceAccount tokens when
config.server.auth.serviceAccount.authorityis set. Public Session suspend/resume RPCs and UI controls are removed; the Session staysREADYwhile its Actor gives back capacity between turns and wakes on the next message.What the docs now say: The Identity page now explains opaque
Principal.IDvalues, service-account TokenReview authentication, and runtimeRuntimeBindingscoping. The UI, architecture, and core concepts pages no longer describe public Session suspend/resume controls and now state that conversation lifecycle is platform-managed.Not verified: No cluster actions were run; the configuration is unrun, and internal links are unchecked.
How
kagent-3358was drafted, and what was not verifiedPlan, and what changed it
examples/agent-substrate.mdstill usessessionIdfor CheckpointService calls and Actor naming, not for the removed Session suspend/resume RPCs.Why a documentation change is necessary
kagent-dev/kagent#3358 adds
config.server.auth.serviceAccount.authorityand a sharedPrincipal.IDmodel for human, machine, and runtime callers. The Identity page already documents controller authentication, but did not mention service-account TokenReview authentication or the opaque principal IDs that the UI now labels as creator IDs. kagent-dev/kagent#3409 removes public Session suspend/resume RPCs and UI controls, while the architecture page and a reused core-concepts snippet still listed those controls as kagent-native Session operations.What changed on disk
docs-site/content/kagent/1.x/about/substrate-runtime/identity.md- Documents opaquePrincipal.IDvalues, service-account TokenReview authentication, corrected trusted-proxy expiry behavior, andRuntimeBindingscoping.docs-site/content/kagent/1.x/observability/launch-ui.md- Explains that the UI has no conversation suspend/resume controls and shows opaque creator IDs.docs-site/content/kagent/1.x/about/architecture/kagent.md- Removes public Session suspend/resume from the kagent control-plane operation list.docs-site/assets/kagent-docs/snippets/about/core-concepts-session-authorization.md- Removes public Session suspend/resume from the reused core-concepts authorization split.How to verify this change
kubectl get clusterrole kagent-kagent-invocation-auth -o yamland confirm that the role grantscreateonauthentication.k8s.iotokenreviews. Runkubectl get clusterrolebinding kagent-kagent-invocation-auth -o yamland confirm that the binding points at the controller ServiceAccount.grpcurl -plaintext localhost:8083 list kagent.api.v1.SessionServiceand confirm that the service lists Session create, read, rename, delete, and share RPCs, but notSuspendSessionorResumeSession.Proposed release note
No
proposed-release-note.md:markers.notes_placeableis false for both items.Suggested text:
config.server.auth.serviceAccount.authority. The controller verifies those tokens with the TokenReview API for thekagent-invocationaudience and uses an opaquePrincipal.ID.READY, and the next interaction wakes the Actor automatically. Explicit suspend/resume controls remain for Sandboxes.What was not verified
cluster-facts.mdwas used only as an API-surface reference; no configuration was applied.How the pages were chosen (triage report)
Feature clusters
These pull requests document one feature between them:
docs-site/content/kagent/1.x/observability/launch-ui.md, so this looks like one change split across pull requests and separate drafts would conflictKept apart on purpose. Merging wrongly produces a guide that documents two things and explains neither, so these are reported for a person to merge rather than grouped automatically:
docs-site/content/kagent/1.x/observability/launch-ui.mdas a candidate, but for one of them it is one page among more than 3, so they are kept apart; merge them if both drafts do land theredocs-site/content/kagent/1.x/observability/launch-ui.mdas a candidate, but for one of them it is one page among more than 3, so they are kept apart; merge them if both drafts do land thereDraft a documentation change
kagent-dev/kagent#3358 — feat(auth): support human and machine principals
kagent-dev/websitePrincipal.ID, replacing the separate user and agent identity fields.docs/architecture/a2a-gateway.mddocs/architecture/oidc-proxy-authentication.mdgo/api/gen/kagent/config/v1/config.pb.gogo/core/internal/grpcserver/interceptors.gogo/core/internal/httpserver/auth/authn.gogo/core/internal/httpserver/auth/proxy_authn.gokagent-dev/kagent#3409 — refactor(session)!: remove public suspend and resume controls
kagent-dev/websitedocs/architecture/runtime-and-lifecycle.mddocs/lifecycle-retries.mdgo/api/gen/kagent/api/v1/sessions.pb.gogo/api/gen/kagent/api/v1/sessions_grpc.pb.gogo/core/internal/grpcserver/policy.gogo/core/internal/grpcserver/session.goDraft branch:
pr-tracker-draft-kagent-3358-plus1