Repository navigation
[Automated] Draft docs (kagent): feat(api): resolve Agent metadata from scoped Actor tokens - #667
Closed
github-actions[bot] wants to merge 1 commit into
Closed
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…om scoped Actor tokens Signed-off-by: GitHub Action <action@github.com>
Contributor
|
Covered by #652 (v1.0.0-rc1 docs update). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kagent-dev/kagent#3362 — feat(api): resolve Agent metadata from scoped Actor tokens
Docs versions:
1.x(first shipped in v1.0.0-rc1)No code-path rule covers 11 touched file(s). The planner could route these only by identifier search, so the candidate pages may miss what they changed, including in the other mode:
docs/architecture/agent-identity-lookup.mdgo/api/gen/kagent/api/v1/agent_identity.pb.gogo/api/gen/kagent/api/v1/agent_identity_grpc.pb.gogo/core/internal/grpcserver/agent_identity.gogo/core/internal/grpcserver/interceptors.gogo/core/internal/grpcserver/policy.goWhat changes for users: Downstream services that receive a scoped Actor JWT can call
AgentIdentityService.ResolveAgentIdentityto learn which Agent the runtime represents. The token must includekagent-agent-info, must not includekagent-runtime, and the response includes Agent metadata plussessionIdandruntimeRevision.What the docs now say: The Identity concept page now explains the Agent identity lookup RPC, its token audience boundary, the Agent metadata that it returns, and that returning
sessionIddoes not grant Session API access.Not verified: No cluster; the configuration is unrun, and internal links are unchecked.
How
kagent-3362was drafted, and what was not verifiedPlan, and what changed it
neighbors/kagent-3359.mdcarries the Actor JWT configuration surface, so this item should document only the lookup behavior that the code diff adds.docs-site/content/kagent/1.x/about/substrate-runtime/identity.md.Why a documentation change is necessary
The pull request adds
AgentIdentityService.ResolveAgentIdentity, a new RPC for downstream services that need to map an Actor token back to the Agent and Session revision that it represents. The target Identity page already explains runtime Actor tokens and thekagent-runtimeaudience, but it did not mention the newkagent-agent-infolookup audience or thesessionIdandruntimeRevisionresponse fields. Without this section, readers would not know that lookup tokens use a separate audience and cannot be reused for Session API access.What changed on disk
docs-site/content/kagent/1.x/about/substrate-runtime/identity.md— added the Agent identity lookup section under Agent runtime calls.How to verify this change
kagent-agent-info, then run a Session that calls that service.sessionId, andruntimeRevision; the same token fails againstkagent.api.v1.SessionService/GetSessionwithUnauthenticated.Proposed release note
No
proposed-release-note.mdfile:markers.notes_placeableis false. Suggested note text: Downstream services can now callAgentIdentityService.ResolveAgentIdentitywith a scoped Actor JWT to resolve the Agent namespace, name, UID, labels, annotations, the bound Session ID, and the pinned runtime revision.What was not verified
How the pages were chosen (triage report)
Feature clusters
These clusters look incomplete. Each names a pull request this run never saw, so documenting the cluster as it stands may describe half a feature — the classic failure is a guide telling a reader to set a field that a later change gave a default. Read the absent pull request before drafting:
Draft a documentation change
kagent-dev/kagent#3362 — feat(api): resolve Agent metadata from scoped Actor tokens
kagent-dev/websiteAgentIdentityService.ResolveAgentIdentity, returning the Agent's namespace, name, UID, labels, and annotations, plus the bound Session ID and its pinned runtime revision.docs/architecture/agent-identity-lookup.mdgo/api/gen/kagent/api/v1/agent_identity.pb.gogo/api/gen/kagent/api/v1/agent_identity_grpc.pb.gogo/core/internal/grpcserver/agent_identity.gogo/core/internal/grpcserver/interceptors.gogo/core/internal/grpcserver/policy.goDraft branch:
pr-tracker-draft-kagent-3362