Skip to content

[Automated] Draft docs (kagent): feat(adk): allow disabling ask_user through runtime defaults - #673

Closed
github-actions[bot] wants to merge 1 commit into
mainfrom
pr-tracker-draft-kagent-3298
Closed

github-actions[bot] wants to merge 1 commit into
mainfrom
pr-tracker-draft-kagent-3298

Conversation

@github-actions

@github-actions github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

kagent-dev/kagent#3298 — feat(adk): allow disabling ask_user through runtime defaults

Docs versions: 1.x (first shipped in v1.0.0-rc1)

No code-path rule covers 9 touched file(s). The planner could route these only by identifier search, so the candidate pages may miss what they changed, including in the other mode:

  • docs/architecture/human-in-the-loop.md
  • docs/architecture/process-configuration.md
  • go/adk/pkg/agent/agent.go
  • go/api/gen/kagent/config/v1/config.pb.go
  • proto/kagent/config/v1/config.proto
  • python/packages/kagent-adk/src/kagent/adk/cli.py
  • ...and 3 more

What changes for users: Operators can set config.runtimeDefaults.builtinTools.disableAskUser: true to remove the built-in ask_user question tool from Go and Python ADK agents, including Shared subagents. The default stays false. Tool approvals and questions from remote A2A agents remain independent.

What the docs now say: The skills example now lists disableAskUser beside the other built-in tool defaults. The human-in-the-loop, A2A, and vLLM pages now say that ask_user is present by default, but the Helm value can remove it for Go and Python ADK agents.

Not verified: The cluster state is unconfigured; the configuration is unrun, and internal links are unchecked.

How kagent-3298 was drafted, and what was not verified

Plan, and what changed it

  • Planned: Add config.runtimeDefaults.builtinTools.disableAskUser beside the existing disableBash documentation.
  • Learned: Grepping the target docs found 1.x pages that still said every kagent agent always gets ask_user.
  • Did: Added the Helm value to the skills page and corrected the stale 1.x HITL, A2A, and vLLM statements.

Why a documentation change is necessary

The pull request adds a controller-wide Helm value, config.runtimeDefaults.builtinTools.disableAskUser, and the diff shows that omitted or false keeps the built-in question tool enabled. The existing skills page already documents config.runtimeDefaults.builtinTools.disableBash, so readers expect the adjacent built-in tool settings there. The human-in-the-loop, A2A, and vLLM pages made absolute claims that the runtime gives every agent ask_user; those claims are now conditional on the new value.

What changed on disk

  • docs-site/content/kagent/1.x/examples/skills.md: Added disableAskUser to the built-in tools Helm values example and table.
  • docs-site/content/kagent/1.x/agents/human-in-the-loop.md: Clarified that ask_user support for the kagent harness can be disabled by config.runtimeDefaults.builtinTools.disableAskUser.
  • docs-site/content/kagent/1.x/examples/a2a-agents.md: Scoped the A2A question example to agents that still have the built-in ask_user tool.
  • docs-site/content/kagent/1.x/setup/model-providers/byo-openai.md: Updated the vLLM tool-calling warning for requests that carry tools and named the Helm opt-out.

How to verify this change

  1. Save a values file with the new setting.
    config:
      runtimeDefaults:
        builtinTools:
          disableAskUser: true
  2. Render the controller configuration from the Helm chart, and validate the rendered file.
    helm template kagent <chart> --namespace kagent --values disable-ask-user.yaml --show-only templates/controller-configmap.yaml | yq '.data."controller.yaml"' > controller.yaml
    kagent config validate --component controller --config controller.yaml
  3. Apply the values to a test installation, wait for the controller rollout, and run an ADK agent that would otherwise call ask_user. The model request should not list an ask_user tool, while unrelated built-in tools such as read_file remain available.

Proposed release note

No proposed-release-note.md: markers.notes_placeable is false. Suggested note text: kagent now supports the controller-wide config.runtimeDefaults.builtinTools.disableAskUser Helm value to remove the built-in ask_user question tool from Go and Python ADK agents, including Shared subagents. The default keeps ask_user enabled, and tool approvals and remote A2A questions remain independent.

What was not verified

  • The cluster state is unconfigured; no configuration was applied to a cluster.
  • The configuration is unrun.
  • Internal links are unchecked because this run did not build the Hugo site.
  • The generated Helm reference was not updated by hand; reference/helm.md is generator-owned.
How the pages were chosen (triage report)

Draft a documentation change

kagent-dev/kagent#3298 — feat(adk): allow disabling ask_user through runtime defaults

  • Product: kagent (upstream) → kagent-dev/website
  • Docs version: 1.x
  • Code issue: [FEATURE] Config to disable/enable "ask_user" tool kagent#2836
  • Summary (read from the body): Automated ADK agents always receive the built-in ask_user tool and can pause waiting for human input. Add controller-wide config.runtimeDefaults.builtinTools.disableAskUser following the existing disableBash configuration pattern.
  • Not tested: no cluster was available, so every command in this diff is unrun
  • No rule covers 9 touched file(s). The candidate pages below come from the files that DID match a rule, so they may scope this narrower than the change is. Read these before deciding the change is only about the pages listed:
    • docs/architecture/human-in-the-loop.md
    • docs/architecture/process-configuration.md
    • go/adk/pkg/agent/agent.go
    • go/api/gen/kagent/config/v1/config.pb.go
    • proto/kagent/config/v1/config.proto
    • python/packages/kagent-adk/src/kagent/adk/cli.py
    • ...and 3 more

Draft branch: pr-tracker-draft-kagent-3298


Important

The test suite has not run on this pull request. It was opened by github-actions[bot], and GitHub does not start workflows for pull requests opened with the repository's own token. This repository's checks are held as action_required until somebody presses Approve and run on the Checks tab. Checks that come from GitHub Apps rather than Actions, such as DCO, run on their own.

Please approve the checks before reviewing the content: an absence of failures here means the tests have not run, not that they passed.

…through runtime defaults

Signed-off-by: GitHub Action <action@github.com>
@Rachael-Graham

Copy link
Copy Markdown
Contributor

Covered by #652 (v1.0.0-rc1 docs update).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants