Repository navigation
[Automated] Draft docs (kagent): feat(adk): allow disabling ask_user through runtime defaults - #673
Closed
github-actions[bot] wants to merge 1 commit into
Closed
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…through runtime defaults Signed-off-by: GitHub Action <action@github.com>
Contributor
|
Covered by #652 (v1.0.0-rc1 docs update). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kagent-dev/kagent#3298 — feat(adk): allow disabling ask_user through runtime defaults
Docs versions:
1.x(first shipped in v1.0.0-rc1)No code-path rule covers 9 touched file(s). The planner could route these only by identifier search, so the candidate pages may miss what they changed, including in the other mode:
docs/architecture/human-in-the-loop.mddocs/architecture/process-configuration.mdgo/adk/pkg/agent/agent.gogo/api/gen/kagent/config/v1/config.pb.goproto/kagent/config/v1/config.protopython/packages/kagent-adk/src/kagent/adk/cli.pyWhat changes for users: Operators can set
config.runtimeDefaults.builtinTools.disableAskUser: trueto remove the built-inask_userquestion tool from Go and Python ADK agents, including Shared subagents. The default staysfalse. Tool approvals and questions from remote A2A agents remain independent.What the docs now say: The skills example now lists
disableAskUserbeside the other built-in tool defaults. The human-in-the-loop, A2A, and vLLM pages now say thatask_useris present by default, but the Helm value can remove it for Go and Python ADK agents.Not verified: The cluster state is
unconfigured; the configuration is unrun, and internal links are unchecked.How
kagent-3298was drafted, and what was not verifiedPlan, and what changed it
config.runtimeDefaults.builtinTools.disableAskUserbeside the existingdisableBashdocumentation.ask_user.Why a documentation change is necessary
The pull request adds a controller-wide Helm value,
config.runtimeDefaults.builtinTools.disableAskUser, and the diff shows that omitted orfalsekeeps the built-in question tool enabled. The existing skills page already documentsconfig.runtimeDefaults.builtinTools.disableBash, so readers expect the adjacent built-in tool settings there. The human-in-the-loop, A2A, and vLLM pages made absolute claims that the runtime gives every agentask_user; those claims are now conditional on the new value.What changed on disk
docs-site/content/kagent/1.x/examples/skills.md: AddeddisableAskUserto the built-in tools Helm values example and table.docs-site/content/kagent/1.x/agents/human-in-the-loop.md: Clarified thatask_usersupport for thekagentharness can be disabled byconfig.runtimeDefaults.builtinTools.disableAskUser.docs-site/content/kagent/1.x/examples/a2a-agents.md: Scoped the A2A question example to agents that still have the built-inask_usertool.docs-site/content/kagent/1.x/setup/model-providers/byo-openai.md: Updated the vLLM tool-calling warning for requests that carry tools and named the Helm opt-out.How to verify this change
ask_user. The model request should not list anask_usertool, while unrelated built-in tools such asread_fileremain available.Proposed release note
No
proposed-release-note.md:markers.notes_placeableisfalse. Suggested note text: kagent now supports the controller-wideconfig.runtimeDefaults.builtinTools.disableAskUserHelm value to remove the built-inask_userquestion tool from Go and Python ADK agents, including Shared subagents. The default keepsask_userenabled, and tool approvals and remote A2A questions remain independent.What was not verified
unconfigured; no configuration was applied to a cluster.reference/helm.mdis generator-owned.How the pages were chosen (triage report)
Draft a documentation change
kagent-dev/kagent#3298 — feat(adk): allow disabling ask_user through runtime defaults
kagent-dev/websiteask_usertool and can pause waiting for human input. Add controller-wideconfig.runtimeDefaults.builtinTools.disableAskUserfollowing the existingdisableBashconfiguration pattern.docs/architecture/human-in-the-loop.mddocs/architecture/process-configuration.mdgo/adk/pkg/agent/agent.gogo/api/gen/kagent/config/v1/config.pb.goproto/kagent/config/v1/config.protopython/packages/kagent-adk/src/kagent/adk/cli.pyDraft branch:
pr-tracker-draft-kagent-3298Important
The test suite has not run on this pull request. It was opened by
github-actions[bot], and GitHub does not start workflows for pull requests opened with the repository's own token. This repository's checks are held asaction_requireduntil somebody presses Approve and run on the Checks tab. Checks that come from GitHub Apps rather than Actions, such as DCO, run on their own.Please approve the checks before reviewing the content: an absence of failures here means the tests have not run, not that they passed.