Repository navigation
Fix string with both length and zeroTerminated options - #318
Merged
Merged
Conversation
keichi
force-pushed
the
fix-string-zero-terminated-length
branch
from
October 18, 2026 14:01
0947ad2 to
28efa80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
generateStringhad two bugs when bothlengthandzeroTerminatedare set:length, it was included in the result, because the end computation could not distinguish "hit NUL at the last byte" from "hit the length limit".lengthwas inlined raw instead of going throughctx.generateOption, so function lengths caused a SyntaxError and field-name lengths became bare (undefined) identifiers.Repro
Fix
Evaluate the length once via
ctx.generateOptioninto a tmp variable, scan until the limit or a NUL (without consuming it), decode[start, offset), then skip the NUL if one was found. Offset semantics are unchanged (advances just past the NUL, or bylengthif none). Added regression tests.