Repository navigation
Reject string types in choice() and wrapped() when varName is omitted - #325
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
choice()orwrapped()is called without a variable name and the type is a string (an alias registered withnamely(), or a primitive type forchoice), the generated code assigns the result tovarsitself, discarding all previously parsed fields.Repro
Same with
wrapped({ length: 1, wrapper: (b) => b, type: "A1" }).Fix
Add build-time validation equivalent to the one
nest()already has ("type must be a Parser object if the variable name is omitted."):wrapped(): throw iftypeis not a Parser object and varName is omitted.choice(): throw if any choice ordefaultChoiceis a string and varName is omitted.Validation was chosen over merging with
Object.assignbecause it matchesnest()'s existing behavior, and merging cannot work for primitive choices (a number cannot be merged intovars). Regression tests added intest/composite_parser.ts.