[FayeSGW]

Summary

• Rename the MERKELY_SLACK_CI_FAILURES_WEBHOOK secret to SLACK_CI_FAILURES_WEBHOOK everywhere it is referenced.
• Remove the slack_channel and slack_webhook secret declarations from the reusable test.yml and docker.yml workflows, and the matching pass-throughs from main.yml, release.yml, and daily-cli-tests.yml. Neither reusable workflow ever read them; the ci-failures notification is sent by the calling workflow's own slack-notification-on-failure job.
• Add a slack-notification-on-failure job to release.yml, mirroring the one in main.yml. Previously a test failure during a release produced no ci-failures message at all.

Notes for reviewers

• The new release job depends on every job in the release pipeline, so it fires on any failure, not only test failures. Trim the needs list if that is too broad.
• SLACK_CI_FAILURES_WEBHOOK must exist as a repo or org secret before this merges, otherwise the notification steps receive an empty URL.

🤖 Generated with Claude Code

[claude]

Claude finished @FayeSGW's task in 1m 1s —— View job

---

Follow-up review complete

Reviewed the new commits (0a2d0ccd..2ef1c3e9), which touch only .github/workflows/release.yml — adding notify-start to the slack-notification-on-failure job's needs list and extending its if condition to also treat cancelled as a failure.

Previous finding status:

• ✅ Resolved — needs list out of sync with notify-finish (missing notify-start): fixed, the two lists now match exactly.
• ✅ Resolved — cancelled not treated as failure (unlike notify-finish): fixed, the if condition now includes contains(join(needs.*.result, ','), 'cancelled').
• The optional suggestion to add a comment noting the two needs lists should be kept in sync was not added, but it was explicitly optional and the underlying risk is otherwise mitigated by the lists now matching.

Closed the resolved review thread with a reply.

New findings: none. The diff is minimal and doesn't introduce any new bugs or regressions.

• Fetch existing review comments and new commit diff
• Assess status of previous finding (release.yml needs list sync comment / cancelled handling)
• Check changed lines for new bugs/regressions
• Post summary comment
  · Branch