Repository navigation
cookbook: apply review suggestions from #443 - #467
Merged
Merged
Conversation
Log "read" on the read path of the net websocket example (the docs page renders this file), and use a deferred server.Close() in its test, matching the gorilla test. Follow-up to #443 by @wakqasahmed. Claude-Session: https://claude.ai/code/session_01QKDYQr53zNKkR7nif2CAAq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #443 (thanks @wakqasahmed), applying the two review suggestions that could not be pushed to the fork:
cookbook/websocket/net/server.go: the read path logged "failed to write WS message"; it now says "read". The docs page renders this file.cookbook/websocket/net/server_test.go: use a deferredserver.Close(), matching the gorilla test. The upgraded connection is hijacked, soClosedoes not wait on it.go vetandgo test -race ./cookbook/websocket/...pass.https://claude.ai/code/session_01QKDYQr53zNKkR7nif2CAAq