Repository navigation
docs: regenerate diagrams for log indexes - #508
Merged
Merged
Conversation
…dexes The persistence diagram now pins main after batch format 6, so its citations move with the code: Duck moved to internal/engine and the trace read cites both index lookups.
|
No actionable comments were generated in the recent review. Walkthrough
Change: Other Merge Risk:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch format 6 (#507) added
logs.fidx, but the diagram SVGs were not regenerated. This renders them with archify 3.1.0 and moves the persistence diagram's evidence pin to main after #507. That re-resolves its citations:Duckmoved tointernal/engine, and line numbers shifted. The trace read now cites both index lookups.Summary by CodeRabbit