Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #301 (inequalities), which is stacked on #300, #299 and the rc4 pin in #298. Hold until #298 merges. Replaces #278.
The parsing is in lambda-feedback/lambda-feedback-packages#13.
x = y = znow parses toAnd(Eq(x, y), Eq(y, z)). Before, only the first two operands were kept, sox = y = wwas marked correct againstx = y = z. A single=still parses to a bareEquality.x = = yandx = y < zare parse errors.Behaviour (unchanged from #278)
z = y = x,y = x = z,2x = 2y = 2z,x + 1 = y + 1 = z + 1x = y = zx = y = w,x = y = 5x = y = zx = y = yx = yx = y = zx = yCHAIN_NOT_EQUALITYx = yx = y = zEQUALITY_NOT_CHAINWhere it goes
app/context/symbolic/equalities.py:equality_parts,is_equality_chainandcheck_equality_equivalence.linear_eq_to_matrix.MAX_CHAINED_EQUALITY_PARTS.EqualityComparisonenum, and each member's name is the criterion tag suffix. Support chained equalities in the answer and response #278's bareexcept Exceptionis nowexcept ValueError(sympy'sNonlinearError)._equality_equivalenceinto_compare_single_equality._equality_equivalencenow callscheck_equality_equivalence.check_equality: chains are caught before thelhs - rhssubtraction, the same as inequalities.app/context/symbolic/graphs/equivalence.py: two new outcomes,CHAIN_NOT_EQUALITYandEQUALITY_NOT_CHAIN.criterion_equality_nodeusesequality_parts, so it also handles chains.app/feedback/symbolic.py: the two new strings.app/docs/user.mdandapp/docs/dev.md.# TODO: Remove when criteria for checking proportionality is implemented.PROPORTIONAL_TOhas existed since 472319a, and moving the equality check onto it wouldn't change behaviour.Tests
symbolic_evaluation_test.py, and its preview test intosymbolic_preview_test.py. The parser tests are in packages#13.test_radians_to_frequency, which fails before this PR too.check_equalitycomplexity rises to 15.🤖 Generated with Claude Code