Repository navigation
fix: Clear selectorless FDv2 state in client and server SDKs - #640
Draft
kinyoklion wants to merge 1 commit into
Draft
kinyoklion wants to merge 1 commit into
kinyoklion wants to merge 1 commit into
Conversation
Co-Authored-By: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
launchdarkly/ld-relay#979 serves FDv2 full transfers that carry no selector:
payload-transferred {"state":"","version":0}. The SDKs stored the empty state as a present selector, so both the polling path (params().append({"basis", ...})) and the streaming path (params().set("basis", ...)) sent an emptybasis=. The contract test that covers this is launchdarkly/sdk-test-harness#600.libs/internal/src/fdv2_protocol_handler.cpp(shared by client and server): an empty transferredstatenow produces an absent selector, so poll and stream URLs leave outbasis.libs/server-sdk/.../fdv2_data_system.cpp: when a payload arrives without a selector, the selector the SDK was holding is cleared. A no-change response still keeps it.Verification
client_impl.cpponly builds FDv1 or null sources), so the harness can't reach this code path. The client change is covered by unit tests only.Link to Devin session: https://app.devin.ai/sessions/f3b22e19bdde48f1b39f77808077390b
Open in Devin Desktop: https://app.devin.ai/desktop/session/f3b22e19bdde48f1b39f77808077390b?variant=devin
Requested by: @kinyoklion
SDK-3596