Repository navigation
fix: Default the FDv1 fallback to polling, and stop synthesizing one in contract tests - #641
Merged
Merged
Conversation
Co-Authored-By: Bee Klimt <bklimt@launchdarkly.com>
Co-Authored-By: Bee Klimt <bklimt@launchdarkly.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
There was a problem hiding this comment.
Automated risk review (dry run): Medium
This PR would not be automatically approved. Human approval required.
Why: FDv2Builder::Default() in libs/server-sdk/src/config/builders/data_system/fdv2_builder.cpp changes the Server SDK FDv1 fallback from streaming to polling, which is a default runtime behavior change. Human approval is needed; no reviewers were assigned.
Sent by Cursor Approval Agent: Dry-Run PR Approver
kinyoklion
approved these changes
Nov 16, 2026
kinyoklion
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Server SDK only. Fixes SDK-3062 and SDK-3064.
FDv2Builder::Default()now usesFDv1Fallback(FDv1Polling{})rather thanFDv1Streaming{}, which matches the other server SDKs.Custom()is unchanged and has no fallback.entity_manager.cpp) configures an FDv1 fallback only when the harness providesfdv1Fallback. It no longer derives one from the synchronizers. It already builds fromCustom(), so the new default doesn't affect it.fdv1Fallbackthat has nobaseUri: its endpoint is still derived from the synchronizers.The suppression for
directive without FDv1 fallback configured halts the data systemstays. The test still fails locally on the v3 harness without it. That scenario sends HTTP 500 along with the directive. The Beast SSE path handles the 500 with its own internal backoff and never calls the synchronizer error callback, so the directive never reaches the data system. That's a networking-layer issue separate from these config fixes. I updated the suppression's comment to describe it.Link to Devin session: https://app.devin.ai/sessions/52b49035b924421789239f17165acccb
Open in Devin Desktop: https://app.devin.ai/desktop/session/52b49035b924421789239f17165acccb?variant=devin
Requested by: @beekld
Note
Overview
FDv2 default config now wires
FDv1Fallbackas polling instead of streaming, aligning the C++ server SDK with other server SDKs.Custom()still ships with no fallback.The contract test harness only applies an FDv1 fallback when the scenario config includes
fdv1Fallback; it no longer auto-builds one from the synchronizer list (endpoint derivation for an explicit fallback withoutbaseUriis unchanged).Tests expect the polling default and add coverage for custom/no fallback, disabling default fallback, and overriding with streaming. A contract-test suppression comment was refreshed to note streaming still retries on HTTP 500 when no fallback is configured.
Reviewed by Cursor Bugbot for commit 6b44abf. Bugbot is set up for automated code reviews on this repo. Configure here.