Skip to content

fix: Default the FDv1 fallback to polling, and stop synthesizing one in contract tests - #641

Merged
beekld merged 2 commits into
mainfrom
devin/1794868780-cpp-fdv1-fallback-defaults
Nov 17, 2026
Merged

beekld merged 2 commits into
mainfrom
devin/1794868780-cpp-fdv1-fallback-defaults

Conversation

@beekld

@beekld beekld commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Server SDK only. Fixes SDK-3062 and SDK-3064.

  • SDK-3062: FDv2Builder::Default() now uses FDv1Fallback(FDv1Polling{}) rather than FDv1Streaming{}, which matches the other server SDKs. Custom() is unchanged and has no fallback.
  • SDK-3064: The contract test service (entity_manager.cpp) configures an FDv1 fallback only when the harness provides fdv1Fallback. It no longer derives one from the synchronizers. It already builds from Custom(), so the new default doesn't affect it.
  • I left the existing behavior alone for an explicit fdv1Fallback that has no baseUri: its endpoint is still derived from the synchronizers.

The suppression for directive without FDv1 fallback configured halts the data system stays. The test still fails locally on the v3 harness without it. That scenario sends HTTP 500 along with the directive. The Beast SSE path handles the 500 with its own internal backoff and never calls the synchronizer error callback, so the directive never reaches the data system. That's a networking-layer issue separate from these config fixes. I updated the suppression's comment to describe it.

Link to Devin session: https://app.devin.ai/sessions/52b49035b924421789239f17165acccb
Open in Devin Desktop: https://app.devin.ai/desktop/session/52b49035b924421789239f17165acccb?variant=devin
Requested by: @beekld


Note

Overview
FDv2 default config now wires FDv1Fallback as polling instead of streaming, aligning the C++ server SDK with other server SDKs. Custom() still ships with no fallback.

The contract test harness only applies an FDv1 fallback when the scenario config includes fdv1Fallback; it no longer auto-builds one from the synchronizer list (endpoint derivation for an explicit fallback without baseUri is unchanged).

Tests expect the polling default and add coverage for custom/no fallback, disabling default fallback, and overriding with streaming. A contract-test suppression comment was refreshed to note streaming still retries on HTTP 500 when no fallback is configured.

Reviewed by Cursor Bugbot for commit 6b44abf. Bugbot is set up for automated code reviews on this repo. Configure here.

devin-ai-integration Bot and others added 2 commits November 16, 2026 22:43
Co-Authored-By: Bee Klimt <bklimt@launchdarkly.com>
Co-Authored-By: Bee Klimt <bklimt@launchdarkly.com>
@beekld
beekld requested a review from a team as a code owner November 16, 2026 22:44
@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@cursor cursor Bot added the risk:medium label Nov 16, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated risk review (dry run): Medium

This PR would not be automatically approved. Human approval required.

Why: FDv2Builder::Default() in libs/server-sdk/src/config/builders/data_system/fdv2_builder.cpp changes the Server SDK FDv1 fallback from streaming to polling, which is a default runtime behavior change. Human approval is needed; no reviewers were assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Dry-Run PR Approver

@beekld
beekld merged commit 8df0d7d into main Nov 17, 2026
58 checks passed
@beekld
beekld deleted the devin/1794868780-cpp-fdv1-fallback-defaults branch November 17, 2026 00:24
@github-actions github-actions Bot mentioned this pull request Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants