Repository navigation
fix: Prevent TestDataV2 from restoring an old flag builder when the flag key is a Symbol - #495
Merged
Merged
Conversation
…lag key is a Symbol TestDataV2 stored a flag builder under the key that the caller passed to flag. use_preconfigured_flag discards the builder under the String key from the flag data, so it missed a builder that flag(:key) created. A later flag(:key) then returned the old builder, and update replaced the preconfigured flag with it. flag and FlagBuilderV2 now convert the key to a String. A Symbol key and a String key get the same builder, and a built flag has a String key, as a flag from LaunchDarkly has.
joker23
approved these changes
Nov 12, 2026
…l-flag-keys # Conflicts: # lib/ldclient-rb/integrations/test_data/flag_builder.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestDataV2 stored a flag builder under the key that the caller passed
to flag. use_preconfigured_flag discards the builder under the String
key from the flag data, so it missed a builder that flag(:key) created.
A later flag(:key) then returned the old builder, and update replaced
the preconfigured flag with it.
flag and FlagBuilderV2 now convert the key to a String. A Symbol key
and a String key get the same builder, and a built flag has a String
key, as a flag from LaunchDarkly has.
Note
Overview
Fixes a TestData bug where passing a Symbol flag key (e.g.
flag(:myflag)) stored builders under a different hash key than String keys, souse_preconfigured_flagcould fail to clear the builder and later updates resurrected stale configuration.TestData#flagandFlagBuildernow coerce keys to strings, so symbol and string accessors share one builder and built flags expose a stringkey. Specs cover preconfigured replacement, builder reuse, and stored flag keys when symbols are used.Reviewed by Cursor Bugbot for commit 5c406c8. Bugbot is set up for automated code reviews on this repo. Configure here.