Skip to content

Fix ROCm ccache build caching and update to ROCm 10.1.0 - #1890

Merged
leejet merged 2 commits into
leejet:masterfrom
lemonade-sdk:master
Oct 10, 2026
Merged

leejet merged 2 commits into
leejet:masterfrom
lemonade-sdk:master

Conversation

@superm1

@superm1 superm1 commented Aug 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Using mtime doesn't work with wheels, need to compare content.

Related Issue / Discussion

This was reported in llama.cpp, it should be same problem here.

Checklist

Summary by CodeRabbit

  • Builds
    • Updated Windows and Ubuntu ROCm builds to use ROCm 10.1.0 and a new package source.
    • Improved Ubuntu build caching to reduce repeated compilation.

@superm1 superm1 changed the title Fix ROCm ccache build caching Fix ROCm ccache build caching and update to ROCm 10.0.0 Aug 27, 2026
@superm1

superm1 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

@leejet with these changes CI will be much faster for multiple builds on the same day.

@superm1

superm1 commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

@leejet can you take a look?

@leejet

leejet commented Oct 6, 2026

Copy link
Copy Markdown
Owner

The ccache fix looks reasonable, but I think we should address two issues before merging:

  • Please keep ROCm pinned to ROCM_VERSION in both pip install commands. The index already contains 10.1.0, while the cache keys and artifact names still say 10.0.0. Fresh installations and cached Windows installations can therefore use different versions.
  • The Linux GPU target list drops gfx900, gfx906, gfx90c, gfx1103, and gfx1153. Is this intentional for ROCm 10? Please preserve these targets where supported, or retain an older-toolchain build for them and document the compatibility change.

superm1 and others added 2 commits October 9, 2026 23:21
Using mtime doesn't work with wheels, need to compare content.
@superm1 superm1 changed the title Fix ROCm ccache build caching and update to ROCm 10.0.0 Fix ROCm ccache build caching and update to ROCm 10.1.0 Oct 10, 2026
@superm1

superm1 commented Oct 10, 2026

Copy link
Copy Markdown
Contributor Author

Updated.

@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Review in Change Stack →Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f0d8c2d9-44e5-4b39-8a81-550bc4a1027c


📥 Commits

Reviewing files that changed from the base of the PR and between f89d9b1 and 5e9be2c.



📒 Files selected for processing (1)
  • .github/workflows/build.yml


Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.




📝 Walkthrough
📝 Walkthrough

Walkthrough

The Windows and Ubuntu ROCm jobs now use ROCm 10.1.0 and install wheels from a new index. The Ubuntu job adds a 2 GB ccache limit and updates ccache hashing settings.

Changes

ROCm CI configuration

Layer / File(s) Summary
Configure Windows and Ubuntu ROCm jobs
.github/workflows/build.yml
The Windows and Ubuntu jobs use ROCm 10.1.0 and the stable.repo.amd.com/rocm/whl-next/ index. The Windows job renames GPU_TARGETS to gpu_targets. The Ubuntu job adds a 2 GB ccache limit and configures compiler-content hashing and metadata handling.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: leejet



Merge Risk: ⚪ Minimal · up to 5e9be

Both jobs use version-aligned ROCm packages, caches, and artifacts. No concrete merge-blocking workflow regression remains.

Architecture Summary

Architecture risk: 🔵 Low · up to 5e9be

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/build.yml: The Windows ROCm job updates the version from 7.14.0 to 10.1.0 and renames its GPU-target environment variable from GPU_TARGETS to gpu_targets.
  • observed — Modified behavior in .github/workflows/build.yml: The Windows job installs the selected ROCm version from the stable.repo.amd.com/rocm/whl-next/ index instead of the repo.amd.com/rocm/whl-multi-arch/ index.
  • observed — Modified behavior in .github/workflows/build.yml: The Ubuntu ROCm matrix updates its version from 7.14.0 to 10.1.0; its GPU targets are unchanged, and the x64 build value is now quoted.
  • observed — Modified behavior in .github/workflows/build.yml: The Ubuntu ROCm job limits ccache to 2 GB and adds configuration to check compiler contents rather than modification time, while treating time macros and include-file modification and change times as non-significant.


Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title clearly and concisely identifies the two main changes: fixing ROCm ccache build caching and updating to ROCm 10.1.0.
Description check Passed The description includes the Summary, Related Issue / Discussion, and Checklist sections. The Additional Information section is missing, but the description is otherwise focused and sufficiently compl…

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR



  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@leejet
leejet merged commit 05845fd into leejet:master Oct 10, 2026
11 checks passed
@leejet

leejet commented Oct 10, 2026

Copy link
Copy Markdown
Owner

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants