Initialize bases and members in declaration order.

.github/workflows/ci-expanded.yml

@@ -171,7 +171,7 @@ jobs:
             link: "static"
             cc: "gcc-13"
             cxx: "g++-13"
-            flags: "--coverage -fprofile-update=atomic"
+            flags: "--coverage -fprofile-update=atomic -fno-inline"
             coverage: "lcov"
             options: "--enable-isystem"
 

.github/workflows/ci.yml

@@ -99,7 +99,7 @@ jobs:
             link: "static"
             cc: "gcc-13"
             cxx: "g++-13"
-            flags: "--coverage -fprofile-update=atomic"
+            flags: "--coverage -fprofile-update=atomic -fno-inline"
             coverage: "lcov"
             options: "--enable-isystem"
 

builds/cmake/CMakeLists.txt

@@ -63,6 +63,7 @@ project( libbitcoin-node
   DESCRIPTION "Bitcoin Full Node"
   LANGUAGES C CXX )
 
+set( CMAKE_CXX_SCAN_FOR_MODULES OFF )
 
 set( repository_root_dir "${CMAKE_CURRENT_SOURCE_DIR}/../.." )
 

include/bitcoin/node/channels/channel_peer.hpp

@@ -41,9 +41,9 @@ class BCN_API channel_peer
         const node::configuration& config, const options_t& options) NOEXCEPT
       : node::channel(log, socket, identifier, config),
         network::channel_peer(log, socket, identifier, config.network, options),
+        network::tracker<channel_peer>(log),
         witness_(config.node.require_witness),
-        announcement_cache_(config.node.announcement_cache),
-        network::tracker<channel_peer>(log)
+        announcement_cache_(config.node.announcement_cache)
     {
     }
 

include/bitcoin/node/protocols/protocol_block_in_31800.hpp

@@ -37,13 +37,13 @@ class BCN_API protocol_block_in_31800
     protocol_block_in_31800(const auto& session,
         const network::channel::ptr& channel, bool performance_enabled=true) NOEXCEPT
       : protocol_performer(session, channel, performance_enabled),
+        network::tracker<protocol_block_in_31800>(session->log),
         top_checkpoint_height_(
             session->system_settings().top_checkpoint().height()),
         block_type_(session->node_settings().require_witness ?
             type_id::witness_block : type_id::block),
         node_pruned_(session->node_settings().limited_blocks),
-        map_(chaser_download::empty_map()),
-        network::tracker<protocol_block_in_31800>(session->log)
+        map_(chaser_download::empty_map())
     {
     }
 

include/bitcoin/node/protocols/protocol_block_out_106.hpp

@@ -35,8 +35,8 @@ class BCN_API protocol_block_out_106
     protocol_block_out_106(const auto& session,
         const network::channel::ptr& channel) NOEXCEPT
       : node::protocol_peer(session, channel),
-        node_witness_(session->node_settings().provide_witness),
-       network::tracker<protocol_block_out_106>(session->log)
+        network::tracker<protocol_block_out_106>(session->log),
+        node_witness_(session->node_settings().provide_witness)
     {
     }
 

include/bitcoin/node/protocols/protocol_block_out_70001.hpp

@@ -35,8 +35,8 @@ class BCN_API protocol_block_out_70001
     protocol_block_out_70001(const auto& session,
         const network::channel::ptr& channel) NOEXCEPT
       : protocol_block_out_106(session, channel),
-        enable_not_found_(session->network_settings().enable_not_found),
-        network::tracker<protocol_block_out_70001>(session->log)
+        network::tracker<protocol_block_out_70001>(session->log),
+        enable_not_found_(session->network_settings().enable_not_found)
     {
     }
 

include/bitcoin/node/protocols/protocol_observer.hpp

@@ -38,14 +38,14 @@ class BCN_API protocol_observer
     protocol_observer(const auto& session,
         const network::channel::ptr& channel) NOEXCEPT
       : node::protocol_peer(session, channel),
+        network::tracker<protocol_observer>(session->log),
         relay_disallowed_
         (
             std::dynamic_pointer_cast<network::channel_peer>(channel)->
                 is_negotiated(network::messages::peer::level::bip37) &&
             !session->network_settings().enable_relay
         ),
-        group_(to_group<std::decay_t<decltype(*session)>>()),
-        network::tracker<protocol_observer>(session->log)
+        group_(to_group<std::decay_t<decltype(*session)>>())
     {
     }
 

include/bitcoin/node/protocols/protocol_performer.hpp

@@ -40,11 +40,11 @@ class BCN_API protocol_performer
     protocol_performer(const auto& session,
         const network::channel::ptr& channel, bool enabled) NOEXCEPT
       : node::protocol_peer(session, channel),
+        network::tracker<protocol_performer>(session->log),
         deviation_(session->node_settings().allowed_deviation > 0.0),
         enabled_(enabled && to_bool(session->node_settings().sample_period_seconds)),
         performance_timer_(system::emplace_shared<network::deadline>(session->log,
-            channel->strand(), session->node_settings().sample_period())),
-        network::tracker<protocol_performer>(session->log)
+            channel->strand(), session->node_settings().sample_period()))
     {
     }
 

include/bitcoin/node/protocols/protocol_transaction_in_106.hpp

@@ -36,9 +36,9 @@ class BCN_API protocol_transaction_in_106
     protocol_transaction_in_106(const auto& session,
         const network::channel::ptr& channel) NOEXCEPT
       : node::protocol_peer(session, channel),
+        network::tracker<protocol_transaction_in_106>(session->log),
         tx_type_(session->node_settings().require_witness ?
-            type_id::witness_tx : type_id::transaction),
-        network::tracker<protocol_transaction_in_106>(session->log)
+            type_id::witness_tx : type_id::transaction)
     {
     }
 

include/bitcoin/node/protocols/protocol_transaction_out_106.hpp

@@ -35,8 +35,8 @@ class BCN_API protocol_transaction_out_106
     protocol_transaction_out_106(const auto& session,
         const network::channel::ptr& channel) NOEXCEPT
       : node::protocol_peer(session, channel),
-        node_witness_(session->node_settings().provide_witness),
-        network::tracker<protocol_transaction_out_106>(session->log)
+        network::tracker<protocol_transaction_out_106>(session->log),
+        node_witness_(session->node_settings().provide_witness)
     {
     }
 

include/bitcoin/node/protocols/protocol_transaction_out_60002.hpp

@@ -35,8 +35,8 @@ class BCN_API protocol_transaction_out_60002
     protocol_transaction_out_60002(const auto& session,
         const network::channel::ptr& channel) NOEXCEPT
       : protocol_transaction_out_106(session, channel),
-        enable_memory_pool_(session->network_settings().enable_memory_pool),
-        network::tracker<protocol_transaction_out_60002>(session->log)
+        network::tracker<protocol_transaction_out_60002>(session->log),
+        enable_memory_pool_(session->network_settings().enable_memory_pool)
     {
     }
 

include/bitcoin/node/protocols/protocol_transaction_out_70001.hpp

@@ -35,8 +35,8 @@ class BCN_API protocol_transaction_out_70001
     protocol_transaction_out_70001(const auto& session,
         const network::channel::ptr& channel) NOEXCEPT
       : protocol_transaction_out_60002(session, channel),
-        enable_not_found_(session->network_settings().enable_not_found),
-        network::tracker<protocol_transaction_out_70001>(session->log)
+        network::tracker<protocol_transaction_out_70001>(session->log),
+        enable_not_found_(session->network_settings().enable_not_found)
     {
     }
 

src/chasers/chaser.cpp

@@ -31,10 +31,10 @@ using namespace system::chain;
 BC_PUSH_WARNING(NO_THROW_IN_NOEXCEPT)
 
 chaser::chaser(full_node& node) NOEXCEPT
-  : node_(node),
+  : reporter(node.log),
+    node_(node),
     strand_(node.service().get_executor()),
-    top_checkpoint_height_(node.system_settings().top_checkpoint().height()),
-    reporter(node.log)
+    top_checkpoint_height_(node.system_settings().top_checkpoint().height())
 {
 }
 

src/settings.cpp

@@ -32,8 +32,8 @@ settings::settings() NOEXCEPT
   : network{ chain::selection::none },
     threads{ 0 },
     delay_inbound{ true },
-    memory_priority{ true },
     thread_priority{ true },
+    memory_priority{ true },
     provide_blocks{ true },
     require_blocks{ true },
     provide_witness{ true },
@@ -44,20 +44,20 @@ settings::settings() NOEXCEPT
     use_gpu{ true },
     cpu_batch_verify{ false },
     cpu_batch_silent{ false },
-    batch_verify{ 1'000'000 },
-    batch_silent{ 1'000'000 },
+    allowed_deviation{ 1.5 },
     minimum_fee_rate{ 0.000001 },
     minimum_bump_rate{ 0.0 },
-    allowed_deviation{ 1.5 },
+    batch_verify{ 1'000'000 },
+    batch_silent{ 1'000'000 },
     current_connections{ 10 },
     announcement_cache{ 42 },
     fee_estimate_horizon{ 0 },
     ////snapshot_bytes{ 200'000'000'000 },
     ////snapshot_valid{ 250'000 },
     ////snapshot_confirm{ 500'000 },
     maximum_height{ 0 },
-    silent_start_height{ 0xffffffff_u32 },
     maximum_concurrency{ 50'000 },
+    silent_start_height{ 0xffffffff_u32 },
     sample_period_seconds{ 10 },
     compact_timeout_seconds{ 10 },
     compact_missing_percent{ 50 },