Skip to content

Accept Clojure examples that start their own server - #277

Closed
tony wants to merge 1 commit into
clojure-portfrom
fix/clojure-examples-no-launcher
Closed

tony wants to merge 1 commit into
clojure-portfrom
fix/clojure-examples-no-launcher

Conversation

@tony

@tony tony commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Needed before libtmux/libtmux-java#143 merges, on top of #276 (clojure-port), which is where the Clojure example reader lives.

Summary

  • attachCompleteClojureExamples accepts deps.edn alone as well as deps.edn with run.sh. A revision that still ships the launcher reads as before.
  • Without run.sh the page says the program starts a private tmux server of its own, prints clojure -M -m ... with no sh run.sh and no TMUX_BIN advice.
  • New packages/api-model/test/clojure-examples.test.ts covers both layouts and the setup files still refused.

Test plan

…server

why: libtmux-java#143 gives the Clojure facade start! and removes
examples/api/run.sh from its manifest. The Clojure example reader
required deps.edn and run.sh together, called run.sh a launcher and
printed `sh run.sh clojure ...`, so the docs build would fail at the
first revision without it. A revision that still ships it must read as
before.

what:
- Take deps.edn alone, or with run.sh, as the setup files
- Without run.sh, say the program starts a private server of its own
  and print `clojure -M -m ...` without the launcher
- Test both layouts and the setup files still refused
@tony
tony force-pushed the fix/clojure-examples-no-launcher branch from 8847125 to 39d9d44 Compare November 8, 2026 03:49
@tony

tony commented Nov 8, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by ca3ad29 in #276

@tony tony closed this Nov 8, 2026
@tony
tony deleted the fix/clojure-examples-no-launcher branch November 8, 2026 04:08
@tony
tony temporarily deployed to docs-preview-cleanup November 8, 2026 04:08 — with GitHub Actions Inactive

This branch was previously deployed

1 inactive deployment
docs-preview-cleanup — 39d9d44a Deployed Nov 8, 2026 by tony via cleanup #214
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant