Skip to content

Verify OCaml variant constructor destinations - #295

Draft
tony wants to merge 2 commits into
mainfrom
followup/ocaml-constructor-anchors
Draft

tony wants to merge 2 commits into
mainfrom
followup/ocaml-constructor-anchors

Conversation

@tony

@tony tony commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Verify OCaml variant constructor names, declaring types and markup.
  • Reject constructor markers embedded in attributes or comments.
  • Replace the None manual review with verified constructor identity.

References such as Option.None are checked against their type and constructor declarations in the official API markup. Evidence records retain the verified symbol heading. Source validation reuses the captured official Option page.

Test plan

  • Parser cases and adjacent Perl-link and workflow suites.
  • Constructor identities from captured official None and Some declarations.
  • Complete offline API destination consistency gate.
  • Script lint and scoped type-aware test check, with unchanged unused-import warnings.
  • Complete local outer/browser loop; the run reached its 60-second deadline.
  • Focused verification against released main.
  • Complete hosted site audit.

Integration

This draft targets main after the combined new-port release. The complete hosted audit remains the merge gate. The no-preview label holds preview publication. Development-runner budget tracking remains separate in the existing runner issue.

why: Constructor links need declaration evidence for their names and
parent types rather than a manually approved heading.

what:
- Read constructor anchors and validate their type, class and name.
- Reject markers inside quoted attributes and comments.
- Record Option.None's identity and remove its manual review row.
- Cover constructor declarations and mismatched markup.
@tony tony added the no-preview Run CI without publishing a PR preview. label Nov 9, 2026
@tony
tony changed the base branch from release/combined to main November 10, 2026 00:39
why: The constructor destination fix requires verification on the
published shared-docs baseline.

what:
- Merge main with the released navigation and OCaml producer fixes.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-preview Run CI without publishing a PR preview.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant