Repository navigation
raise Vips::Error if copy_memory fails - #443
Merged
Merged
Conversation
vips_image_copy_memory() returns NULL on error, for example when the source cannot be decoded. copy_memory wrapped that pointer without a check, so the next call on the returned image segfaulted. Fixes libvips#442
Member
|
Hi @VitaliiLazebnyi, That's a silly oversight. Thanks for this PR! |
Contributor
Author
|
Thank you for the quick merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #442
vips_image_copy_memory()returns NULL on error (e.g. a truncated image), andcopy_memorywrapped it unchecked, so the next call on the result segfaulted the process, which can't be rescued. It now raisesVips::Error, likewrite_to_memory.The new spec uses the truncated
coffee.gifsample from #419 and fails without the fix.