Repository navigation
Clean up lock entries for rejected KV writes - #1186
Open
benthecarman wants to merge 1 commit into
Open
benthecarman wants to merge 1 commit into
benthecarman wants to merge 1 commit into
Conversation
SqliteStore and PostgresStore register a per-key lock entry before validating the namespace and key, but only remove it after a completed write. Writes and removes rejected by validation therefore left their entry behind, slowly growing the lock map for each distinct invalid key in release builds. Clean up the lock entry when validation fails. This was found by Project Loupe. This change was made with the help of Claude Code.
|
I've assigned @tnull as a reviewer! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLite and Postgres stores add a per-key lock entry before validating the key, but only remove it after a completed write. Writes or removes that fail validation leave the entry behind.
Remove the entry when validation fails.
This could never be hit in practice because we validate beforehand, but better to add in case our API changes.
Found by Project Loupe.