Repository navigation
Use Electrum protocol_version to check package relay support - #1199
Merged
tnull merged 1 commit intoOct 22, 2026
Merged
Conversation
Bump `electrum-client` to 0.25.2, which ships the `protocol_version()` API (rust-electrum-client#213). Use it to check whether the configured Electrum server supports `blockchain.transaction.broadcast_package` (introduced in protocol v1.6), rather than probing by broadcasting a dummy TRUC package. Drafted with the help of Claude Code.
|
I've assigned @tnull as a reviewer! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #949
This resolves the TODO in
ElectrumChainSource::validate_zero_fee_commitments_support.electrum-clientfrom0.25to0.25.2. 0.25.1 addedElectrumApi::protocol_version(), and 0.25.2 bumpswebpki-roots.blockchain.transaction.broadcast_package. Previously, we broadcast a dummy package to find out. The version is cached when the client connects, so the check usually needs no extra round-trip.This PR was drafted with the help of Claude Code.