Skip to content

LCORE-0000: use gpt mini against release06 branch - #3029

Open
snuryyeva wants to merge 1 commit into
lightspeed-core:mainfrom
snuryyeva:snuryyeva/gpt_mini_fix
Open

snuryyeva wants to merge 1 commit into
lightspeed-core:mainfrom
snuryyeva:snuryyeva/gpt_mini_fix

Conversation

@snuryyeva

@snuryyeva snuryyeva commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Description

When E2E runs for PRs targeting release/0.6, /v1/query is returning 500. Llama Stack logs show OpenAI 400 from the safety path:

File "/Users/sonuryye/Documents/projects/lightspeed-stack/.venv/lib/python3.12/site-packages/openai/_base_client.py", line 1716, in request
    raise self._make_status_error_from_response(err.response) from None
openai.BadRequestError: Error code: 400 - {'error': {'message': "Unsupported value: 'temperature' does not support 0.0 with this model. Only the default (1) value is supported.", 'type': 'invalid_request_error', 'param': 'temperature', 'code': 'unsupported_value'}}

Cause : On 0.6, Lightspeed calls input moderation before the main LLM on /query unless the client sends "shield_ids": []. Moderation goes through Llama Stack inline::llama-guard, which calls the configured shield model with temperature=0.0. gpt-5.6-luna does not allow that; gpt-4o-mini does.

Solution : To force Github Actions to choose gpt-4o-mini when PR targets release06.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library [pyproject.toml + uv.lock]
  • Bump-up dependent library [requirements.*.txt for Konflux]
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

  • Assisted-by: (e.g., Claude, CodeRabbit, Ollama, etc., N/A if not used)
  • Generated by: (e.g., tool name and version; N/A if not used)

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Summary by CodeRabbit

  • Chores
    • Updated automated test configuration for the 0.6 release branch. Other branches continue using the configured test model.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 634d32e and 7048e6e.

Files selected for processing: 1
  • .github/workflows/e2e_tests.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details
Context from checks skipped due to timeout: 27
  • GitHub Check: E2E: library / ci / default
  • GitHub Check: E2E: library / ci / shields
  • GitHub Check: E2E: server / ci / shields
  • GitHub Check: E2E: library / ci / mcp
  • GitHub Check: E2E: library / ci / skills
  • GitHub Check: E2E: library / ci / other
  • GitHub Check: E2E: server / ci / authorized
  • GitHub Check: E2E: server / ci / other
  • GitHub Check: E2E: server / ci / skills
  • GitHub Check: E2E: library / ci / authorized
  • GitHub Check: E2E: library / ci / rbac
  • GitHub Check: E2E: server / ci / tls
  • GitHub Check: E2E: server / ci / default
  • GitHub Check: E2E: server / ci / mcp
  • GitHub Check: E2E: server / ci / rbac
  • GitHub Check: unit_tests (3.12)
  • GitHub Check: unit_tests (3.14)
  • GitHub Check: unit_tests (3.13)
  • GitHub Check: integration_tests (3.12)
  • GitHub Check: integration_tests (3.13)
  • GitHub Check: integration_tests (3.14)
  • GitHub Check: Pylinter
  • GitHub Check: build-pr
  • GitHub Check: Red Hat Konflux / lightspeed-core-0-8-enterprise-contract / lightspeed-stack-0-8
  • GitHub Check: Red Hat Konflux / lightspeed-stack-0-8-e2e-tests / lightspeed-stack-0-8
  • GitHub Check: Red Hat Konflux / rag-content-0-8-e2e-tests / lightspeed-stack-0-8
  • GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-0-8-on-pull-request
Additional context used
zizmor (1.30.1)
.github/workflows/e2e_tests.yaml

[warning] 2-358: overly broad permissions (excessive-permissions): default permissions used due to no permissions: block

(excessive-permissions)

[warning] 18-358: overly broad permissions (excessive-permissions): default permissions used due to no permissions: block

(excessive-permissions)

Additional comments: 1
.github/workflows/e2e_tests.yaml: 1

110-110: LGTM!

Walkthrough

The E2E workflow uses gpt-4o-mini for pull requests targeting release/0.6. For other base branches, it uses vars.E2E_OPENAI_MODEL.

Changes

E2E model selection

Layer / File(s) Summary
Select the E2E model
.github/workflows/e2e_tests.yaml
The workflow selects gpt-4o-mini when the base branch is release/0.6. Otherwise, it uses vars.E2E_OPENAI_MODEL.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: are-ces, tisnik

Merge Risk: Minimal · up to 7048e

The workflow model selection matches the stated branch-specific behavior.

Pre-merge checks: Passed 7
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: use GPT Mini for the release/0.6 branch in E2E tests.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Performance And Algorithmic Complexity Passed PASSED. The pull request changes only the E2E_OPENAI_MODEL workflow environment expression in .github/workflows/e2e_tests.yaml. It adds no loops, API calls, list operations, parsing work, caches, …
Security And Secret Handling Passed No security violation is introduced by the changed line. The workflow now selects the literal model name gpt-4o-mini for release/0.6; it does not add a secret, token, endpoint, or user-controlled …
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Performance And Algorithmic Complexity

Explanation

PASSED. The pull request changes only the E2E_OPENAI_MODEL workflow environment expression in .github/workflows/e2e_tests.yaml. It adds no loops, API calls, list operations, parsing work, caches, buffers, or endpoint changes. No meaningful performance regression matches the check criteria.

Full details: Security And Secret Handling

Explanation

No security violation is introduced by the changed line. The workflow now selects the literal model name gpt-4o-mini for release/0.6; it does not add a secret, token, endpoint, or user-controlled command/path input. The existing API key handling and authorization gate are unchanged.

Finishing Touches: 💡 1
🧪 Generate unit tests (beta)
  • Create a new PR
✨ Simplify code
  • Create a new PR
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant