Repository navigation
docs: keep activityRelations as one unpartitioned table for now - #5350
Conversation
Refs linuxfoundation/lfx-cdp-insights-ops#821 Signed-off-by: Uroš Marolt <uros@marolt.me>
PR SummaryLow Risk Overview The ADR captures size/growth context, why time-, segment-, and archive-based options were rejected, and operational risks (autovacuum, ~50M rows/month growth trigger, redundant indexes). Reviewed by Cursor Bugbot for commit 672bb2c. Bugbot is set up for automated code reviews on this repo. Configure here. |
[Low impact] The documentation changes appear safe to merge. SummaryRecords the decision to keep
The previous finding is fixed. No new actionable issues were found. Reviews (2) · Last reviewed commit: "docs: qualify issue links and correct th..." · Reviewed by Greptile |
There was a problem hiding this comment.
🟡 Changes recommended
The ADR needs explicit links to the correct issue tracker and a corrected partitioning rationale that distinguishes existing dedup index columns from the separate primary-key constraint.
2 open issues
What changed in this PR
Records the decision to keep PostgreSQL’s activityRelations table unpartitioned for now, following cleanup, maintenance and ingestion improvements. This is documentation-only; no schema or runtime behavior changes.
Changes:
- Adds ADR-0039 with table size, growth estimates and reasons for deferring partitioning or archiving.
- Documents maintenance risks, index-review opportunities and conditions for revisiting the decision.
- Registers the accepted ADR in the index.
| File | Description |
|---|---|
docs/adr/README.md |
Adds the ADR-0039 index entry. |
docs/adr/0039-keep-activity-relations-unpartitioned.md |
Records the storage decision, alternatives, consequences and revisit criteria. |
Review effort: Balanced
…ADR-0039 Refs linuxfoundation/lfx-cdp-insights-ops#821 Signed-off-by: Uroš Marolt <uros@marolt.me>
There was a problem hiding this comment.
🔵 Needs a closer look
The storage decision depends on production growth, latency, and VACUUM evidence that cannot be verified from the checkout or inaccessible private epic, requiring confirmation by a database owner.
No open issues 🎉
2 resolved since last review
Review effort: Balanced

Summary
Records the storage decision for
activityRelationsfrom epic linuxfoundation/lfx-cdp-insights-ops#821: keep it as one unpartitioned table for now. The duplicate cleanup (#852), the NULL-channel unique index (#1114), the firstVACUUMand the data-sink-worker speedups removed the load that made partitioning look necessary.Changes
docs/adr/0039-keep-activity-relations-unpartitioned.md:docs/adr/README.md: index row for ADR-0039.Type of change
Related issue
Refs linuxfoundation/lfx-cdp-insights-ops#821