Repository navigation
P2p sidecar - #39
P2p sidecar#39
Conversation
mStream 6.21+ fetches its p2p discovery sidecar binary on first use, sha256-verified against a manifest committed in the app tree. Baking it at image build (the app ships a script for exactly this) means discovery works in containers with no runtime egress to github.com and with no first-enable download; the fetch is pinned+verified either way, and images inherit new pins on their normal rebuilds. Runtime fetch remains as the fallback for anything else, so nothing breaks for older images. Verified: built the x86_64 image, then in a --network none container the baked binary executes (--print-id returns a valid node id) as user abc. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Bake the p2p discovery sidecar into the image at build time
|
I am a bot, here are the test results for this PR for commit f369ceb :
|
|
I am a bot, here are the test results for this PR for commit a23cc40 :
|
github-project-automation
Bot
moved this from PRs Ready For Team Review
to PRs Approved
in Issue & PR Tracker
|
I am a bot, here are the test results for this PR for commit e9162ea :
|
|
Hey I just wanted to bump this ticket and see if it's ready to merge |
|
@IrosTheBeggar sorry this got held up because we had to have a larger internal discussion about AI agents as authors in commits to our repos. We didn't have a policy about it so we had to figure it out. All good now and ready to merge. Thanks. |
#37 redo for ci tests