Repository navigation
REST Sites: Fix network permission checks and add delete permission coverage - #9
Merged
lloc merged 1 commit intoOct 1, 2026
Conversation
Combines check_network_ids_exist() and check_network_access() into one check_network_ids() method, used consistently across get_items, get_item, create_item, update_item, and delete_item_permissions_check(). Also adds test coverage for delete_item_permissions_check() network validation, which previously had none. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Owner
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_items_permissions_check()(existence/access checks now run before edit/own-user permission checks) and adds the same network-ID validation todelete_item_permissions_check(), which previously performed no network check at all before allowing deletion of a site on a network the requester has no access to.check_network_ids_exist()andcheck_network_access()into a singlecheck_network_ids()method, used consistently byget_items,get_item,create_item,update_item, anddelete_item_permissions_check(), removing repeated boilerplate at all 5 call sites.delete_item_permissions_check()'s network validation (invalid network ID, network the user isn't a super admin of, and the allowed case), matching the existing coverage already present forget_items,create_item, andupdate_item.Test plan
npm run test:php -- --filter WP_Test_REST_Sites_Controller -c tests/phpunit/multisite.xml— 154 tests, 555 assertions, all passing.