Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
626cbb6
fix(runtime): honor explicit Goal runtime with conflicting defaults
loopx-agent Nov 12, 2026
89d4dbe
fix(chat): use the Task read route for Todo actions
loopx-agent Nov 12, 2026
3347c7f
fix(chat): create work in the Goal source runtime
loopx-agent Nov 12, 2026
a00b3dc
fix(chat): recover committed Todo and Monitor confirmations
loopx-agent Nov 12, 2026
2070549
fix(chat): recover pending Todo and Monitor display delivery
loopx-agent Nov 12, 2026
658bc66
Fix source-bound Chat task confirmations and integrate main
loopx-agent Nov 14, 2026
347f716
Integrate latest main for the reviewed Chat source changes
loopx-agent Nov 14, 2026
41cffe5
Preserve legacy Todo diagnostics and document source-bound confirmation
loopx-agent Nov 14, 2026
9766ae5
Preserve original Chat creation after interrupted confirmation
loopx-agent Nov 14, 2026
daeec37
Merge remote-tracking branch 'origin/main' into codex/audit-chat-crea…
loopx-agent Nov 14, 2026
05007a8
Keep reviewed create recovery in its Chat Todo owner
loopx-agent Nov 14, 2026
ce03a2b
Integrate reviewed task confirmations and preserve each pending displ…
loopx-agent Nov 14, 2026
fef8b63
Merge remote-tracking branch 'origin/main' into codex/audit-chat-disp…
loopx-agent Nov 14, 2026
9f1667b
Recover an interrupted display acknowledgement by proposal ID
loopx-agent Nov 14, 2026
14b696a
Integrate current main while preserving registered Goal and original …
loopx-agent Nov 14, 2026
7f4621f
Preserve registered Goal navigation and original task confirmation on…
loopx-agent Nov 15, 2026
7bdda5b
Remove the inactive confirmation control from a verified creation rec…
loopx-agent Nov 15, 2026
ca373bb
Merge current main into the Chat confirmation repair
loopx-agent Nov 15, 2026
54c8d23
Restore the original Chat confirmation after its first checkpoint fails
loopx-agent Nov 15, 2026
ec151ea
Preserve the original Chat confirmation across a gateway failure
loopx-agent Nov 15, 2026
d820479
Integrate the current main branch and retain both Chat source guards
loopx-agent Nov 15, 2026
4b8d35b
Keep the shared Chat source module within its line limit
loopx-agent Nov 15, 2026
c0ef35c
Integrate current main into the original Chat confirmation repair
loopx-agent Nov 15, 2026
af94fe6
Recover an interrupted confirmation under its original review
loopx-agent Nov 15, 2026
e4fbd0f
Keep the original confirmation recoverable through display updates
loopx-agent Nov 15, 2026
289299e
Recover Chat assignment against the original Todo authority
loopx-agent Nov 15, 2026
57b0726
Integrate the reviewed-source recovery dependency
loopx-agent Nov 15, 2026
379e72a
Integrate original Chat confirmations with routed Todo recovery
loopx-agent Nov 15, 2026
97482f9
Recover original Chat confirmations after display interruptions
loopx-agent Nov 15, 2026
40de5dd
Verify typed task confirmation after an interrupted apply
loopx-agent Nov 15, 2026
8258ca9
Integrate the packaged confirmation retry validation from #8725
loopx-agent Nov 15, 2026
d0f3b08
Merge commit '289299ebf5b36f252a444b7e7d878f312bbc815f' into codex/ma…
loopx-agent Nov 15, 2026
27302c0
Resume legacy Chat confirmations and fence Monitor creation
loopx-agent Nov 15, 2026
193e6d5
Restore retained Chat confirmations on their original card
loopx-agent Nov 15, 2026
0ba272d
Recover pre-upgrade assignments in pending Chat confirmations
loopx-agent Nov 16, 2026
0f9a474
Integrate current main into Chat confirmation recovery
loopx-agent Nov 16, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/python-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ jobs:
python-version: "3.11"
- name: Install checkout for Python-backed browser scenarios
run: |
python -m pip install --disable-pip-version-check -e .
python -m pip install --disable-pip-version-check -e '.[test]'
echo "LOOPX_TEST_PYTHON=$(python -c 'import sys; print(sys.executable)')" >> "$GITHUB_ENV"
- uses: actions/setup-node@v6
with:
Expand All @@ -193,6 +193,7 @@ jobs:
npm run smoke:delegation-search
npm run smoke:task-inspector-route
npm run smoke:conversation-find
node smoke/todo-confirmation-browser-smoke.mjs
- name: Qualify packaged team evidence and feedback recovery
if: matrix.shard == 2
working-directory: apps/presentation/dashboard
Expand Down

Large diffs are not rendered by default.

131 changes: 131 additions & 0 deletions apps/presentation/dashboard/smoke/todo-confirmation-http-fixture.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,131 @@
"""Packaged Chat confirmation recovery on a disposable authority."""

from pathlib import Path
import json
import socket
import sys
from tempfile import TemporaryDirectory

import pytest

REPO = Path(__file__).resolve().parents[4]


class InterruptedConfirmation(BaseException):
"""End the request before Chat can persist a failure response."""


def main(provider, assets_dir, interrupted_step):
# Run against this checkout when the smoke is launched as a standalone script.
sys.path[:0] = [str(REPO), str(REPO / "tests/control_plane")]
from canonical_authority_fixture import isolate_sqlite_runtime, promoted_create_fixture
from loopx import chat_server
from loopx.chat_action_store import ChatActionStore
from loopx.control_plane.coordination.local_authority import read_canonical_todos_if_promoted
from loopx.control_plane.effect_runtime import restart_effect_runtime
from loopx.control_plane.todos import provider_projection
from loopx.control_plane.todos.mutation_api import add_goal_todo

with TemporaryDirectory(prefix="loopx-confirmation-fixture-") as directory, pytest.MonkeyPatch.context() as patch:
scratch = Path(directory)
isolate_sqlite_runtime(scratch, patch)
registry, runtime, _ = promoted_create_fixture(scratch, provider=provider)
lost = {}
interrupted = set()
display = {"hold": False, "drop_reply": None, "gateway_reply": None, "hold_list": False, "hold_detail": False}
write_state = provider_projection.atomic_write_state_text
checkpoint = ChatActionStore.save_checkpoint
for content in ("Review release checklist", "Verify documentation links", "Check failure handling"):
add_goal_todo(registry_path=registry, goal_id="goal-a", role="agent", text=content)

def interrupt(self, proposal_id, *, step, receipt, **kwargs):
if interrupted_step == "applying" and step == "todo_create_prepared" and proposal_id not in interrupted:
interrupted.add(proposal_id)
raise InterruptedConfirmation()
if step == interrupted_step and proposal_id not in interrupted and not display["hold"]:
interrupted.add(proposal_id)
if step == "todo_created":
lost[proposal_id] = receipt["canonical_receipt"]
raise OSError("test: first create checkpoint write interrupted")
return checkpoint(self, proposal_id, step=step, receipt=receipt, **kwargs)

def render(path, text, **kwargs):
if display["hold"]:
raise PermissionError("test: display disabled after authority commits")
return write_state(path, text, **kwargs)

class FixtureHandler(chat_server.ChatRequestHandler):
def do_POST(self):
if self.path == "/__confirmation_fixture/display":
patch_update = self._read_json()
for name in display.keys() & patch_update.keys():
display[name] = patch_update[name]
self._send_json({"ok": True})
return
if self.path != "/__confirmation_fixture/advance":
try:
return super().do_POST()
except (BrokenPipeError, ConnectionResetError):
return
except InterruptedConfirmation:
self.close_connection = True
return
self._read_json()
add_goal_todo(registry_path=registry, goal_id="goal-a", role="agent", text="Independent authority update")
self._send_json({"ok": True})

def do_GET(self):
if self.path != "/__confirmation_fixture":
route = self.path.split("?", 1)[0]
if ((display["hold_list"] and route == "/api/actions")
or (display["hold_detail"] and route.startswith("/api/actions/"))):
self._send_json({"error": "test: list unavailable"}, status=503)
return
try:
return super().do_GET()
except (BrokenPipeError, ConnectionResetError):
return
snapshot = read_canonical_todos_if_promoted(runtime_root=runtime, goal_id="goal-a")
self._send_json({"provider_revision": snapshot["provider_revision"],
"ids": sorted(todo["todo_id"] for todo in snapshot["todos"]),
"lost": lost})

def _send_json(self, payload, *, status=200):
gateway = display["gateway_reply"]
if gateway and self.path == f"/api/actions/{gateway}/apply":
display["gateway_reply"] = None
body = b"<html><title>Bad Gateway</title></html>"
self.send_response(502)
self.send_header("Content-Type", "text/html")
self.send_header("Content-Length", str(len(body)))
self.end_headers()
self.wfile.write(body)
return
operation = display["drop_reply"]
if operation and self.path == f"/api/actions/{operation}/apply":
display["drop_reply"] = None
self.close_connection = True
self.connection.shutdown(socket.SHUT_WR)
return
return super()._send_json(payload, status=status)

serve = chat_server.ChatHTTPServer.serve_forever

def ready(server):
print(json.dumps({"origin": f"http://127.0.0.1:{server.server_address[1]}"}), flush=True)
return serve(server)

patch.setattr(chat_server, "ChatRequestHandler", FixtureHandler)
patch.setattr(chat_server.ChatHTTPServer, "serve_forever", ready)
patch.setattr(ChatActionStore, "save_checkpoint", interrupt)
patch.setattr(provider_projection, "atomic_write_state_text", render)
try:
chat_server.serve_chat(registry_path=registry, runtime_root_override=runtime, scan_roots=[scratch],
lark_cli_bin="unavailable-test-lark-cli", codex_bin="unavailable-test-codex",
port=0, goal_id="goal-a", assets_dir=assets_dir)
finally:
restart_effect_runtime(wait_for_exit=True)


if __name__ == "__main__":
main(sys.argv[1], Path(sys.argv[2]), sys.argv[3])
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ const todoBasis = {
provider_revision: z.string().min(1),
source_authority: z.enum(["file_v0", "sqlite_v0"]),
registry_sha256: digest,
source_identity: digest.optional(),
};

// Decode existing backend contracts; effect authority and stale-source checks
Expand Down
1 change: 1 addition & 0 deletions apps/presentation/dashboard/src/data/chat.ts
Original file line number Diff line number Diff line change
Expand Up @@ -476,6 +476,7 @@ export const typedActionProposalSchema = z.object({
gate: z.record(z.string(), z.unknown()).nullable().optional(),
error: z.record(z.string(), z.unknown()).nullable().optional(),
checkpoint: z.record(z.string(), z.unknown()).nullable().optional(),
creation_retry_available: z.literal(true).optional(),
failure: z.record(z.string(), z.unknown()).nullable().optional(),
canonical_update_basis: actionSourceBasisSchema.optional(),
// The workspace a Goal creation resolved to, named for the owner's review.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -248,13 +248,15 @@ export const ChannelTimeline = memo(function ChannelTimeline({
const appliedTeamPlan = item.proposal.actionKind === "team.plan" && item.proposal.status === "applied";
const taskReceipt = item.proposal.reviewPlan?.taskExecution;
const pendingOperation = item.proposal.reviewPlan?.operationFrame?.kind === "pending";
const pendingDisplay = item.proposal.reviewPlan?.reason === "canonical_create_projection_pending";
return (
<Fragment key={item.id}><button className={`personal-proposal-row is-${item.proposal.status}`} data-action-kind={item.proposal.actionKind} onClick={() => onSelect({ item: item.proposal, kind: "proposal" })} type="button">
<span><Sparkles size={17} /></span>
<span><small>{pendingOperation ? t(`proposal.kind.${item.proposal.actionKind}`)
<span><small>{pendingDisplay ? t("goalWork.displayPending")
: pendingOperation || item.proposal.reviewPlan?.reason === "todo_creation_retry" ? t(`proposal.kind.${item.proposal.actionKind}`)
: taskReceipt ? t("drawer.taskLaunchReceipt")
: appliedTeamPlan ? (locale === "zh-CN" ? "团队分配 · 已记录" : "Team assignment · Recorded")
: `${t(`proposal.kind.${item.proposal.actionKind}`)} · ${t(`proposal.status.${item.proposal.status}`)}`}</small><strong>{item.proposal.title}</strong>{item.proposal.impact ? <p>{item.proposal.impact}</p> : null}</span>
: `${t(`proposal.kind.${item.proposal.actionKind}`)} · ${t(`proposal.status.${item.proposal.status}`)}`}</small><strong>{item.proposal.title}</strong>{item.proposal.impact && !pendingDisplay ? <p>{item.proposal.impact}</p> : null}</span>
<b>{taskReceipt ? t("feedback.taskStartRequested")
: item.proposal.status === "gated" && item.proposal.actionKind !== "operation.execute" ? t("timeline.review")
: item.proposal.primaryLabel ?? t("timeline.reviewAndConfirm")}</b>
Expand Down
Loading
Loading