Skip to content

test(codex): make native coverage capture portable across POSIX shells - #8924

Closed
loopx-agent wants to merge 1 commit into
codex/c1-work-contract-review-20261107from
codex/c1-native-bash-fixture-20261117
Closed

loopx-agent wants to merge 1 commit into
codex/c1-work-contract-review-20261107from
codex/c1-native-bash-fixture-20261117

Conversation

@loopx-agent

Copy link
Copy Markdown
Collaborator

Goal And Delivered Outcome

Linux 上原生 Codex 默认选择 /bin/sh 时,observed-coverage 夹具的 Bash pipefail 捕获命令在读取前失败,导致恢复矩阵无法检验 C1 的接受与拒绝行为。共享测试 helper 现在明确选择 /bin/bash,保留管道失败传播及所有原有断言。

  • Outcome basis / gap: reproducible test portability defect; this PR is the scoped repair basis.
  • Before → after: 同一 Linux 0.162.1、源码和带子进程回收器的隔离容器,原矩阵 2 passed / 10 failed;显式 Bash 后 12 passed。
  • Intended base: codex/c1-work-contract-review-20261107,关联 C1: unify work sources and validate recovery #8266。

Author Declaration

  • Written by: model_agent, OpenAI GPT-6 Codex.
  • Specification and revision: existing test_native_code_mode_resume_requires_observed_coverage contract at 1d42038bf0d9820a5335ad00bccb0c35713e196d; no separate written specification for the shell portability repair.
Criterion Disposition Path Evidence
Coverage evidence must precede native resume; missing/changed evidence must reject continuity implemented tests/control_plane/test_codex_context_boundary.py unchanged assertions across all 12 existing parameterized cases
Preserve pipeline failure propagation on POSIX hosts implemented same test helper explicit Bash; Linux failing-before / passing-after
  • Self-check: reviewed the single-file diff, native results, DCO and public boundary. No production decision owner, protocol, vocabulary or default was changed.

Scope And Continuation

Complete within this fixture scope. Product resume logic, policy and assertions are unchanged. #8266 retains its own current-head review, required validation and release/adoption work. The separate container orphan-reaping issue belongs to its provider lifecycle; this patch does not redefine zombie-process liveness.

Validation

  • Tested revision: c74b3da6855954d76ff813518e97ee4b97004f19. Native tests ran on this exact file content over the prior C1 tree; base 4267014484 and updated base 1d42038bf0 have identical Git trees.
  • Run state: finished.
  • Input classes: synthetic.
Check kind Result Evidence / limitation
real_entrypoint passed Existing 12-case native Codex exec/app-server coverage-resume matrix, Linux x86-64 0.162.1: 12 passed in 117.06s
regression_parity passed Same Linux matrix before helper fix: 2 passed / 10 failed; failures occurred before resume because /bin/sh rejects pipefail
real_entrypoint passed Same 12 cases on macOS native Codex 0.169.0-alpha.11.1: 12 passed in 34.41s
static passed Focused Ruff, diff check, changed-Python compile, bilingual-RFC diff check (no paired RFC changed), single-file public boundary scan
integration passed Quick diff-selected premerge: 5 direct checks and 3 catalog canaries passed

Coverage includes complete/partial observed reads and unchanged negative cases for missing/altered coverage, stop/Todo/source/content/compaction/repeated tool input. Native binaries ran against isolated source/editable installs and a synthetic local inference endpoint; no subscription inference was used. Linux qualification requires a process reaper in the container. Windows and the broader native suite were not run. Full-wheel preparation was not qualified: a separate source build lacked generated frontend assets; this fixture validation used the documented editable source path.

Frontend / Visual Evidence

UI impact: none; no user-visible surface changed. Screenshots and viewport review: N/A.

Type of Change

  • Test update

LoopX Area

  • Host or runtime integration

Shared-authority RFC fixture impact

N/A: no authority, provider routing or migration semantics changed.

Boundary Checklist

  • No credentials, private state, raw traces/verifier output, internal links or local machine paths are published.
  • No maintainer-owned benchmark run was duplicated.
  • Scope is the reproduced fixture defect.
  • No paired RFC changed.
  • UI impact is none.
  • Commit has a DCO Signed-off-by trailer.

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
@mergify

mergify Bot commented Nov 17, 2026

Copy link
Copy Markdown

This pull request has merge conflicts with codex/c1-work-contract-review-20261107 and cannot be merged
until they are resolved. Please rebase or merge the base branch, @loopx-agent.

Choose the remote for the base repository, not an out-of-date fork.
For a fork clone, first inspect git remote -v; upstream must point
to https://github.com/loopx-project/loopx.git. If it is absent, add it
with git remote add upstream https://github.com/loopx-project/loopx.git.
Then run:

git fetch upstream
git rebase upstream/codex/c1-work-contract-review-20261107
# Resolve each conflict, git add the resolved files, then git rebase --continue.
git push --force-with-lease origin HEAD

For a same-repository clone whose origin points to
https://github.com/loopx-project/loopx.git, use origin instead of
upstream for fetch/rebase. If you prefer merging the base, use
git merge <base-remote>/codex/c1-work-contract-review-20261107 and push normally.

Keep the DCO Signed-off-by trailer on every commit when you rebase.
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify Bot added the needs-rebase Mergify: the pull request has merge conflicts with its base branch label Nov 17, 2026
@loopx-agent

Copy link
Copy Markdown
Collaborator Author

Closing as superseded by the target branch. Its current head, 3694648413192f32b7245be09ae225df66ce7006, already invokes the native capture fixture with /bin/bash and additionally sets login: false to preserve the qualified CLI path. The intended fix is therefore present upstream; retaining this separate PR would duplicate that test change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Mergify: the pull request has merge conflicts with its base branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant