Repository navigation
fix(release): derive runtime snapshot defaults from committed behavior - #9018
Conversation
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
loopx-agent
left a comment
There was a problem hiding this comment.
Reviewer: model_agent · gpt-6.2-sol · OpenAI (runtime_reported, max)
Approval conclusion (author-owned PR; GitHub blocks formal self-approval)
动机 / Motivation
维护者通过 main 或 stable 构建供用户安装的 runtime 快照,安装器会按描述符选择渠道制品。原构建器直接把受支持的 quota_packet 写入描述符和归档,实际源代码默认执行的是 complete_turn,错误会延迟到安装资格检查才暴露。候选先探测本次提交的默认 writer,两个渠道在不合格时都保护已有输出,受支持的历史来源仍可构建和验证。本次复核覆盖分发器与隔离安装验证,正式发布和 C1 采用资格仍由现有发布契约负责。
改动思路 / Approach
沿用安装资格已有的隔离 CLI 探测和分发支持校验。构建器从指定 commit 提取运行时与脚本,读到真实默认 writer 后才创建输出目录。同一份观测写入归档与渠道描述,安装端仍独立检查实际安装对象。直接复用隔离探测比新增常量或检查工作树配置更贴近实际制品。渠道资格和发布审批沿用既有 owner。
具体改动 / Changes
精确 head bcc87fbdd3bf819e05877a02b163805eb2463b1d,diff base 648d06db542075dc023caeeb11ea368b35ef7ab7,3 个文件 +66/-11。逐项复核 supported-writer、immutable-descriptor-binding、prior-output-recovery。验收约定
关键代码讲解
- 构建脚本在校验 frontend 与提交一致之后,从 Git 对象提取提交态的运行时和脚本。同一支持校验处理实际默认 writer,拒绝发生在创建产物目录之前。源码
- 相同的默认 writer 进入不可变归档身份与渠道描述。main 与 stable 的实际入口均核对新目录不存在、已有描述符及相邻文件字节保留。源码
- 回归用例将工作树文件改成不同内容,核对探测读取的是提交版本,并逐项检查两个渠道的支持和拒绝。运行发布、更新与安装用例另得 192 通过、3 跳过。源码
- 使用发布过的 2.3.0 源码与同版本 frontend 生成快照。安装资格独立读回真实的 quota_packet,并验证安装、重装、Doctor、Chat HTTP 和注入故障后的执行路径回退。源码
对主干的风险 / Risks
两种构建入口在 base 生成 quota_packet 描述,但从同一源码独立观察到 complete_turn。候选均在写制品前拒绝。标准预检 5 项直接检查通过,19 项选中检查有 18 项通过。唯一失败是相同的旧 Vision smoke,base 也触发 acceptance_gaps KeyError。把候选与 #9020 和当时最新 main 组合后,原父级 smoke 通过。
语义与 CI 对齐
本轮验证的实际 writer、归档身份和已装来源均可读回。C1 的同单会话成果、完整成本和支持 profile 采用门仍处于发布验收范围,测试只覆盖本机隔离制品及恢复。
我的整体评价 / Verdict
当前精确头无阻断发现。批准构建器按提交态观测及前置拒绝的改动。独立预检仍有可复现的旧 smoke 失败,组合修复及正式发布各有自己的验收。
English verdict: APPROVE. Both snapshot producers now fail before output for an unqualified committed writer. The supported 2.3.0 source installs and recovers in isolation. The standalone Vision smoke fails on base and head.
Problem
The channel builder writes a supported
quota_packetdefault into the runtime descriptor and archive identity before observing the source. On current main648d06db54, both declarations sayquota_packetwhile the ordinary CLI in the committed runtime producescomplete_turn. The installed qualification rejects that candidate later. Distribution gate #8952Change
Run the existing isolated default-contract probe over committed runtime files before writing channel outputs. Both declarations use the validated observation. A rejected source leaves existing output intact. Installed qualification independently repeats the observation on the installed candidate.
Validation
bcc87fbdd3.92271fe114and its digest-verified frontend. The snapshot passed isolated installation, reinstall, Doctor, installed Chat HTTP, and recovery from an injected activation failure.KeyError: 'acceptance_gaps'on both the unchanged main and this PR head. That check remains failed.The clean local preview integrating the separately reviewable smoke migration passed all five direct and 19 selected standard checks. Smoke migration #9020
The current 2.4.0 Desktop candidate stops at the C1 distribution gate. End-to-end release qualification still needs the original matched single-session outcomes, full costs, and supported-profile evidence.