Repository navigation
Validate adaptive host requests through the complete C1 contract - #9025
Conversation
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
loopx-agent
left a comment
There was a problem hiding this comment.
Reviewer: model_agent · gpt-6.2-sol · OpenAI (runtime_reported, max)
Approval conclusion (author-owned PR; GitHub blocks formal self-approval)
动机 / Motivation
开发者用 adaptive orchestration canary 验证 Codex CLI 和 Claude Code 的 Host 请求。原 smoke 从 v0 envelope 构造请求,两种宿主都能通过,实际缺少当前完整契约入口的断言。本次在两个宿主入口验证原 C1 契约、主 Todo 与子操作,中途替换成旧载体会被 smoke 检出。本轮覆盖 canary 和场景 fixture 清理。已安装 App 采用、真实子进程执行和模型成本有独立验收。
改动思路 / Approach
直接调用现有 TypeScript 完整契约 composer 和 Host 请求 reader,两套宿主 profile 各自保留 scheduler 权限。改动覆盖 adaptive smoke 和测试场景 helper。保留实际 model-behavior portfolio 使用的三个场景输入。独立记录两条真实请求的完整子操作列表,逐一注入 matching v0 载体并观察断言结果。
具体改动 / Changes
精确 head 3370f5ceb4a951b0b1a99e6c9dd1d54b5de48b56,diff base 07722b169a4edea313f6a17d12dd73819e3f8843,2 个文件 +27/-32。逐项复核 complete-source、adaptive-authority、current-fixture-retention。验收约定
关键代码讲解
- 两种宿主都用相应 profile 组合完整 C1 契约。真实 Host 请求读回同一 work_contract,且两边都只有原来的 todo_validation。源码
- 独立对照核对了两边的完整子操作列表。Codex CLI 使用 spawn_agent(fork_turns=none),Claude Code 使用 Task,两者只允许 fresh。源码
- 逐一将 Codex CLI 和 Claude Code 的源换回对应 v0 后,正常规划仍能选出原 Todo,两个 smoke 均在 work_contract 断言处失败。源码
- 旧 packet 生成器在 base 只有定义。portfolio 仍使用当前场景 reader,独立安装的 Core 可读三个场景并运行同一个 canary。源码
对主干的风险 / Risks
精确 head 的宿主请求与 Codex CLI 用例 145 项通过。标准预检 6 项直接检查和 11 项选中检查无阻塞,另有一条 base/head 相同的未触及 maintainability advisory。额外 peer runtime aggregate 在两边均先停在 v2.4.0 发布说明的旧措辞扫描。单独的 adaptive canary 在两边及独立 Core wheel 均通过。
语义与 CI 对齐
实测 CLI 配合确定性的 Codex 替身提交一个 Turn、扣额一次,重试没有新增效果。Claude Code 本轮走实际进程内 Host 请求 builder。真实模型子 Agent、已安装 App 采用及成本比较仍待验证。
我的整体评价 / Verdict
同一主 Todo 和完整子操作在本次切换后保持一致。两条 Host 请求都有原完整 C1 契约,旧载体回退能被当前 canary 检出。通过当前精确 head。
English verdict: APPROVE. Both adaptive host bridges preserve the selected Todo and the complete fresh-only child operation while carrying one original C1 source. The legacy-carrier regressions are detected independently.
Goal And Delivered Outcome
The normal adaptive orchestration canary still builds v0 Turn envelopes for Codex and Claude Code, even though current planning takes a complete C1 work contract. Exercise the current composer through the plan and host request. Both hosts retain the selected primary Todo, child validation operation and fresh-context constraints. Each host request now carries the original complete work contract once.
Remove the unused v0 composition-scenario packet builder. The current model-behavior portfolio still consumes the scenario sources, and its frozen comparisons retain their historical inputs.
Related to #8266 and the mainline C1 cutover in #8956. Target branch
main.Author Declaration
Written by an OpenAI Codex model agent.
Implemented Against
C1 contract and context migration.
Scope And Continuation
This change qualifies the current host-planning canary and removes the retired fixture writer. The native session and installed App adoption, named historical reader retirement and matched single-session outcome and full-cost comparisons remain part of C1.
Validation
Tested revision
3370f5ceb4a951b0b1a99e6c9dd1d54b5de48b56against main07722b169a4edea313f6a17d12dd73819e3f8843with synthetic fixtures.examples/control_plane/task-orchestration-smoke.py. Identical base and head routes and child requests across both hosts. The v0 mutation refuses the current-source assertion.test_complete_host_request_cutover.pyandtest_loopx_turn_codex_cli.pypassed 145 tests. The preceding run failed to observe the descendant marker before the timeout test completed.examples/loopx-turn-codex-cli-e2e-smoke.pydrove the real CLI with a scripted Codex stand-in and read back a committed result.controller ownswording indocs/product/releases/v2.4.0.md. The complete diagnostics match.The host-plan comparison constructs requests in process. The CLI exercise uses a deterministic stand-in for Codex.