Skip to content

Preserve explicit Monitor Todo selection in quota polling - #9099

Open
loopx-agent wants to merge 1 commit into
mainfrom
codex/fix-monitor-poll-target-admission-20261119
Open

loopx-agent wants to merge 1 commit into
mainfrom
codex/fix-monitor-poll-target-admission-20261119

Conversation

@loopx-agent

Copy link
Copy Markdown
Collaborator

Goal and delivered outcome

#9093 lets a caller observe a secondary due Monitor by supplying its Todo ID. The CLI also resolves a target key to a Todo internally for receipts. That derived ID could select a different due Monitor even when the caller supplied only its target key.

The quota decision now carries whether the Todo ID was supplied explicitly. A key alone must match the scheduled Monitor. An explicit ID can still identify another due Monitor claimed by the same Agent, subject to existing gates. Pending transactions retain their frozen admission when the receipt matches the original effect.

The patch also removes the unused Markdown renderer forwarding and the wrapper around the shared clock. The lookback smoke now uses an isolated fixture registry.

Author declaration

Criterion Disposition Owner Evidence
Match the scheduled Monitor by key and preserve both records on rejection Implemented monitor_poll_admission.ts File and SQLite public CLI cases
Admit an explicit secondary Todo subject to due, claim and User gates Implemented monitor_poll_admission.ts Public CLI and native admission cases
Preserve original authority on retry Implemented monitor_poll_commit.ts Frozen receipt regression and lease recovery cases

Scope and continuation

This fixes quota Monitor admission independently of Chat. The same Monitor smoke passes in a local composition with #8717 at d1668e0e9ada. That Chat PR still needs review of its current head.

Validation

  • Tested 77da4e2f8e43d531cc3ddb9ef1553120a2993440 against 477def5c176ab4df92ac19ea1dd616828b325e87.
  • Run state finished. Input classes synthetic and public_fixture.
Check Result Evidence
regression_parity passed Main accepted the alternate target key. The candidate rejected it without changing either Todo and accepted the explicit ID.
real_entrypoint and real_backend passed Full monitor-poll-writeback-smoke.py on the candidate and combined Chat tree. File and SQLite canonical CLI cases covered selection, writeback and receipt recovery.
integration passed 100 focused Python cases and 96 TypeScript Monitor and Steward cases.
static passed Control-plane TypeScript typecheck, Ruff on the changed Python files, and RFC bilingual diff check.
integration passed All six direct and 19 selected local premerge checks.
static failed Required repository Ruff and kernel mypy report identical findings on main and this head. The merge gate remains held. See #9082.

Frontend and visual evidence

  • UI impact none. This change affects admission on the existing CLI route.
  • Source data none.

Type and area

  • Bug fix
  • Documentation and test update
  • Control plane

Boundary checklist

  • Diff and evidence contain public-safe code and isolated fixture results.
  • Scope stays within Monitor admission and its validation.
  • No paired RFC changed. The bilingual diff check passed.
  • The commit carries DCO sign-off.

Carry Todo selection provenance into quota admission. Preserve explicit secondary Monitor polling and recovery from previously admitted receipts.

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant