Repository navigation
tickets/SP-3085 add DP2 206.2 on deblender footprints - #225
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
christinawilliams
changed the title
christinawilliams
changed the title
| @@ -0,0 +1,1095 @@ | |||
| { | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Done! Thanks!
| @@ -0,0 +1,1095 @@ | |||
| { | |||
There was a problem hiding this comment.
Please update section numbering to end with a period (e.g., '1.2.'). This comment applies to other sections, where relevant.
Reply via ReviewNB
There was a problem hiding this comment.
Whoops thanks for catching that. Fixed.
| @@ -0,0 +1,1095 @@ | |||
| { | |||
There was a problem hiding this comment.
The description for parentObjectId is a bit confusing. How about "the unique ID of the object's parent blend" or something better?
Reply via ReviewNB
There was a problem hiding this comment.
good idea, fixed
| @@ -0,0 +1,1095 @@ | |||
| { | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
It was to update the footprint area from pixel to arcsec (which is what the cutout takes as input) this is now fixed.
| @@ -0,0 +1,1095 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,1095 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,1095 @@ | |||
| { | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
I wrote it into the caption, its not possible to ask the scarlet lite built-in function to change the labels (the intensity unit is inherited from the image itself so it can change)
| @@ -0,0 +1,1095 @@ | |||
| { | |||
There was a problem hiding this comment.
What kind of measurements you're referring to here? Could you be a bit more specific?
Reply via ReviewNB
There was a problem hiding this comment.
Ok I updated the text to be clearer what is going on. Hopefully it is better now.
| @@ -0,0 +1,1095 @@ | |||
| { | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Fixed i.e.
There was a problem hiding this comment.
Ok I clarified the difference between the 3rd panels in Figs 6 and 7, hopefully this is ok now
| @@ -0,0 +1,1095 @@ | |||
| { | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
This was a mistake, I fixed it thanks for noticing!
galaxyumi
left a comment
galaxyumi
left a comment
There was a problem hiding this comment.
Hi Christina, this is a very helpful tutorial, but a bit difficult to follow. With a bit of rearranging and extra explanations, it will turn out to be great! I left some comments. Please let me know if you have any questions.
|
Thanks Yumi! I think I have addressed all the feedback. please let me know if there's more feedback or suggestions. |
ab22f93 to
84dd29f
Compare
adding 206.2 tutorial notebook on deblender footprints