Repository navigation
jrob93-patch: deep_coadd save to fits - #227
Merged
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
jeffcarlin
self-requested a review
October 14, 2026 17:43
garrethmartin
self-requested a review
October 28, 2026 09:10
| @@ -74,7 +74,7 @@ | |||
| "### 1.1. Import packages\n", | |||
Contributor
There was a problem hiding this comment.
Line #1. # save_file = "{}/deep_coadd_{}_{}_{}_{}.fits".format(
save_file = os.path.join(userdir, ...) is slightly safer
Reply via ReviewNB
| @@ -74,7 +74,7 @@ | |||
| "### 1.1. Import packages\n", | |||
Contributor
There was a problem hiding this comment.
Line #9. # print("save file: {}".format(save_file))
i think it would be make sense to print the message after you save (e.g. save file -> saved to) so the user knows the cell has actually run and saved a file.
Reply via ReviewNB
| @@ -74,7 +74,7 @@ | |||
| "### 1.1. Import packages\n", | |||
Contributor
There was a problem hiding this comment.
i would also maybe remove the comments above so the code actually runs and just delete the file during cleanup.
os.remove(save_file)
Reply via ReviewNB
garrethmartin
approved these changes
Oct 28, 2026
garrethmartin
left a comment
garrethmartin
left a comment
Contributor
There was a problem hiding this comment.
looks good to go after minor comments addressed :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick addition to 202.1 to demo saving a deep_coadd
CellCoaddobject to fits file using.write()