Repository navigation
DM-56549: DP2 NB: initial flags-related tutorial(s) for Object - #233
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
b32bdb3 to
fba61af
Compare
0a5a85a to
705812c
Compare
| @@ -24,7 +24,7 @@ | |||
| "Data Release: [Data Preview 2](https://dp2.lsst.io)\\\n", | |||
There was a problem hiding this comment.
| @@ -0,0 +1,1051 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,1051 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,1051 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,1051 @@ | |||
| { | |||
There was a problem hiding this comment.
It's kinda unclear what is meant by "the baseline set of flag cuts" here. Maybe say "...set of flag cuts as recommended in https://dp2.lsst.io/products/flags/flag_usage.html#object-table"?
Reply via ReviewNB
| @@ -0,0 +1,1051 @@ | |||
| { | |||
There was a problem hiding this comment.
I wonder if the "edge" and "sensor_edge" flags should be removed, since for Object table we're using cell-based coadds, which should (by design) never have edges. (But it's OK to keep them just to confirm that there all zeros I guess.)
Reply via ReviewNB
| @@ -0,0 +1,1051 @@ | |||
| { | |||
There was a problem hiding this comment.
"an object whose moments failed" might be confusing to users, partly because "moments" may not be familiar, and partly because the 3 flags listed don't seem to have anything to do with shape measurement?
Another point: what is "{band}_i_flag"? It's not listed in the recommended flags documentation for the Object table, and its description in the schema browser is "General failure flag", which isn't informative.
Reply via ReviewNB
| @@ -0,0 +1,1051 @@ | |||
| { | |||
There was a problem hiding this comment.
I think the grey points should be a little bigger or a little darker (higher alpha), or maybe both, for visibility. They're kinda hard to see on my screen.
Reply via ReviewNB
| @@ -0,0 +1,1051 @@ | |||
| { | |||
There was a problem hiding this comment.
I'm kinda confused by these histograms. It seems odd to me that the saturated objects are between ~22-24th magnitude. Is that because they are extended objects, and psf mags only capture a fraction of their light?
Reply via ReviewNB
| @@ -0,0 +1,1051 @@ | |||
| { | |||
There was a problem hiding this comment.
Does the floor need to be at 1e-5? Below 1e-3 it's not adding any more information.
Reply via ReviewNB
jeffcarlin
left a comment
jeffcarlin
left a comment
There was a problem hiding this comment.
Overall this is a great tutorial -- it's super useful to be able to visualize the effects of various flags. I left some comments via ReviewNB that you should probably address, but none of them really affect the overall content of the notebook.
One other suggestion: I like the tables outlining the purpose of each flag (like at the beginning of Sec. 3.1 and 3.4). Would it make sense to have something like that for all of the flags in the Introduction? It might be good to have them all together as a reference (and keep the later ones to highlight the focus of each section).
No description provided.