Repository navigation
Conversation
A video without a GPS clock of its own gives nothing to place a GPX track by, and the track is assumed to start with it. A track that runs on past the end of the video for longer than the whole video was not recorded for the video alone: the video could start anywhere along it. Sampling refused such a track from mapillary#841 until mapillary#944, which only warns that the video start time needs aligning with the track. Since then, sampling places the video at the start of whatever the track recorded, such as the first trip of a log of several. Sampling refuses it again, by distance and by interval alike, with the MapillaryGPXVideoStartUnknownError and the message it gave before, which for a track of a day or more says that the track covers more than the video. Nothing is refused when --video_start_time places the video along the track, when --interpolation_offset_time looks the video up along it, or when the video spans the track at --video_duration_ratio. A track shorter than the video, or longer by less than the video lasts, keeps the warning. process, which takes neither --video_start_time nor --video_duration_ratio, still uploads such a track whole, with the warning, as the track of a timelapse runs on past the end of its video too. It refuses only a track of a day or more, a log of several trips whose start is that of the first, unless the video lasts more than half as long. The creation time of the video still places nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A video without a GPS clock of its own gives nothing to place a GPX track by, so the track is assumed to start with the video. A track that runs on past the end of the video for longer than the whole video was not recorded for the video alone: the video could start anywhere along it. Sampling refused such a track from #841 until #944. Since #944 it only warns that the video start time needs aligning with the track, and
video_processsamples the video along the start of whatever the track recorded, such as the first trip of a log of several, months away from the video.This brings the refusal back in sampling, by distance and by interval (
--geotag_source gpx), with theMapillaryGPXVideoStartUnknownErrorand the message it had before #944:For a track of a day or more, the advice is instead: "A track that long covers more than this video: specify the time the video started as --video_start_time".
processtakes neither--video_start_timenor--video_duration_ratio, and the track of a timelapse runs on past the end of its video by design, so it keeps uploading such a track with the alignment warning (listed in the process report since #945). The exception is a track of a day or more, a log of several trips whose start is that of the first, which it now refuses unless the video lasts more than half as long:video_processby distance or by interval, track runs on past the video for longer than the video lastsMapillaryGPXVideoStartUnknownError(exit 7)--video_start_time, with--interpolation_offset_time, or with a--video_duration_ratioat which the track fitsvideo_process, track shorter than the video, or longer by less than the video lastsprocess, track shorter than a dayprocess, track of a day or more, video less than half as longMapillaryGPXVideoStartUnknownErrorThe creation time of the video still places nothing (#946).
--interpolation_use_gpx_start_timerefuses as before.Not changed: interval sampling with
--video_geotag_source gpxreads the track through the video sources, and a refused track leaves its samples ungeotagged, with the refusal logged as a warning, as before #944.Tests: the unit and integration suites. Sampled videos from many cameras before and after: only the five runs with such a track changed, from samples along the wrong part of the track to the refusal.