Repository navigation
style(goose): minimal red unread notification dot in Sources - #51
Merged
Merged
Conversation
…revision; truthful gap loss
…low without row selection
…no invisible source filter
…press new value changes
…press new value changes
…press new value changes
…fail-closed layout changes
…L, security and Inno candidate gates
…obsolete toggle row
…pector with one ACK state
…han per decoded event
…only from clicked Messages row
…nd before/after values
…ight precise changed DataSet entries
…-pane event workflow
…ous/current typed values
… disclose unavoidable bounded evictions
…r for Return to Live
… clear immediately on SSOT ACK and keep tooltip evidence
…r in tooltip and only accent unread values
… event, no accidental ACK of next row
…ntral click/Enter ACK semantics
Base automatically changed from
fix/goose-readable-engineering-ui-20261021
to
main
October 21, 2026 13:05
masarray
marked this pull request as ready for review
October 21, 2026 13:06
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GOOSE tri-pane engineering: Sources → Messages → Data (single source of ACK truth)
Stacked on PR #49. Based on its exact audited head; PR #48 ancestry preserved. No changes to stable published v1.4.1 or unrelated SV/PTP/SCL/phasor modules.
Operator flow
Exact source of truth
GooseTrafficRow.IsUnacknowledgedEventon decoded-event history/pending rows is authoritative.ProjectGooseUnreadIndicators()derives the Sources unread marker;AcknowledgeGooseHistoryEvent()is the one ACK path;InspectNextUnreadGooseSource()is navigation only. Raw decoderGooseValueChangeEvent.Frameis immutable-by-ownership event evidence from the originally decoded packet, not an inference from stNum/sqNum.Verified final checkpoint
Commit:
1bc4fa9954c633bf0f4de239494358544e1bf088Download candidate artifact — unsigned Windows x64 1.4.2 setup + SHA256SUMS + manifest + TRX evidence.
SHA256 installer:
f58a507a91a8b519aded4c66c57303fb1d4dbd37359fa5c56783f8383d26206b(verified against Actions SHA256SUMS). Manifest commit matches the exact final checkpoint.Still awaiting physical acceptance
Keep Draft: do not merge or publish a stable release before real Windows GUI click/Ctrl/Shift/Enter tests, high-rate multi-IED GOOSE, unread source repeated click → next unread row, ACK propagation and re-arming, pinned historical Inspector Data values, scroll behavior at 100/125/150% DPI, and user signoff. Automated green is not physical UI evidence.
GOOSE Data compact tooltip + one-gesture ACK (2026-10-21)
Exact final head:
b25e66ea47270ae0881ec5a7c72d2b6cf3ff168eChangeTooltipText(previous → current), including after acknowledgement. Saved values are never altered to implement ACK.GooseInspectorAlertActivereads only the currently pinned unreadGooseTrafficRow.IsUnacknowledgedEventfrom the existing SSOT journal.GooseInspectorChangedCountTextand the Data row's amber accent both disappear when this precise event is ACKed.AcknowledgeInspectedGooseEvent(). The original UI action is not blocked. A click on a different Messages row first acknowledges the previously inspected event, then navigates to the next row without prematurely acknowledging the newly inspected evidence.AcknowledgeGooseHistoryEventimmediately refreshes the pinned Inspector while deriving Sources unread state from the same Messages journal. Source ACK counts and historical frame evidence remain consistent.Exact-head gate evidence:
Candidate Actions artifact. Unsigned win-x64 v1.4.2 installer, not stable. Installer SHA256
1224d39467f7aec7d5235e97cfd4eb7f4b2bad9d12b758782c5040bbe9b01c25, verified against the workflow SHA256SUMS + exact-head manifest.Acceptance remaining: actual Windows GUI interaction at 100/125/150% DPI, mouse hover tooltip, click-empty-area/Enter ACK, focused row navigation without premature ACK, newest unread value + source/message indicator consistency under live traffic. Keep Draft until operator validates.
Compact source unread indicator — operator screenshot feedback (2026-10-21)
Exact candidate commit:
27715a97323829827c2d3f5f6356e08a66d47475Changedlabel from GOOSE Sources.#F04E5F) in the trailing source-card column only whenHasUnacknowledgedValueChange=true, sourced from the existing SSOT Messages unread journal.UnreadEventTextin tooltip; no extra on-card explanatory text, amber card outline, animation, timer or additional source-card height.verify-workspace-spacing.ps1contract asserts exactly the unobtrusive dot tooltip/binding, noChangedtext, no redundant yellow border.Exact-head validation: Windows CI PASS, runtime stability PASS, runtime architecture PASS, dependency security PASS, Inno package & install/repair smoke PASS, CodeQL (verify latest run conclusion).
Candidate artifact (unsigned v1.4.2 win-x64). Installer checksum:
2929d82454fb2c7602b5bb26fb5c76efa039db5e93a56eff8e5343c471fa7da8(verified against artifact SHA256SUMS; manifest matches exact commit).Still Draft until Windows real-user acceptance; stable release unchanged.