Repository navigation
Install course dependencies from manifest pins - #95
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and behavior
The quick start installed
d2x@latest mcpp@latestbefore downloading the course, and the update guide repeated that command inside existing projects. The default route now gets the course first and runsxlings updatefollowed byxlings install -yin its directory, so.xlings.jsonsupplies the reviewed dependency versions.English, Simplified/Traditional Chinese READMEs, environment guides, and bilingual book instructions follow the same policy. Existing d2x users retain a documented download route followed by project installation. The book workflow also installs from the manifest instead of duplicating the mdBook version. Course dependency versions are unchanged.
Validation
All 28 applicable checks passed on head
7a4a36f232d7405a5a95cb37237bc6ec5e2e1642; two conditional checks (deployment and optional cold diagnostics) were skipped as expected.2026.10.21.1, mcpp2026.10.17.1, mdBook0.4.43; reference answers 52/52 passed; failure → save → pass → advance → restart and preservation of learning progress passed.Self review
No blocking findings. Verified that the default install has no explicit package/version overrides, the manifest remains unchanged, and version assertions check all three declared tools. The optional d2x CI bootstrap reads the course's d2x pin and runs outside project scope. A deliberately older project fixture confirms that bare
xlings installhonors its pin while leaving the outside global latest selection intact. New upstream releases no longer force an automatic course pin bump.The PR has no merge conflicts. Self review does not replace the repository's requirement for two independent approving reviews; those approvals remain pending. This PR has not been merged.