Repository navigation
compat.freetype: the rest of upstream's base extensions and ftbzip2 - #589
Merged
Merged
Conversation
…gasp, fttype1, ftbdf, ftcid, ftpfr, ftwinfnt, ftfstype, ftpatent, ftgxval, ftotval) and ftbzip2
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compat.freetype built only part of upstream's base extensions (
modules.cfgBASE_EXTENSIONS,CMakeLists.txtBASE_SRCS). The public declarations offtstroke.h,ftgasp.h,t1tables.h(FT_Get_PS_Font_Info…),ftbdf.h,ftcid.h,ftpfr.h,ftwinfnt.h,FT_Get_FSType_Flags,FT_Face_CheckTrueTypePatents, the validation entry points andFT_Stream_OpenBzip2therefore linked to nothing. Every distribution builds them. A consumer only notices when it calls one, as cairo did withftsynth.c(#311).The gap showed up while wrapping the whole FreeType API as C++ modules (
mcpplibs.mwrap.freetype, mcpplibs/freetype-m). The stroker is part of that API.pkgs/c/compat.freetype.luaaddssrc/base/{ftbdf,ftcid,ftfstype,ftgasp,ftgxval,ftotval,ftpatent,ftpfr,ftstroke,fttype1,ftwinfnt}.candsrc/bzip2/ftbzip2.c. The list now matches upstream'sBASE_SRCS(2.13.3 and 2.15.0 both have these files). The configuration is unchanged: without the gxvalid/otvalid modules and libbz2, the validation and bzip2 entry points returnFT_Err_Unimplemented_Feature, as in upstream's default build.tests/examples/freetypecalls each newly built translation unit once: it strokes a path and makes each face-level query with a null face.Local:
bash tests/run_members.sh freetypepasses (gcc 16.1.0, Linux).