Repository navigation
Conversation
6 of 10 tasks
obiot
added a commit
that referenced
this pull request
Nov 1, 2026
…idation (#1821) Three fixes by @mmporong, from #1812, #1813 and #1814: - Line#contains() checks the segment endpoints as well as collinearity; a point on the line beyond either endpoint was reported as contained - Color#parseHex() keeps the exact alpha byte of #RRGGBBAA / #RGBA colours instead of rounding it to one decimal (#0000FF01 was fully transparent); toHex8() output is unchanged, and every hex alpha round-trips - isPowerOfTwo() rejects zero, negative and fractional values, and is correct beyond the 32-bit range Co-authored-by: mmporong <mmporong@gmail.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JnzwA4xBNBw7cEZzG1bUru
Member
|
Thank you, @mmporong! This fix is now on I'm closing this one since #1821 merged it. Thanks again for the fix and the regression test. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Line#contains()previously checked only whether a point was collinear with the line. As a result, points beyond either endpoint were reported as contained.This change also checks that both point coordinates fall within the segment's endpoint bounds. A regression test covers collinear points beyond both ends of the segment.
Type of change
Checklist
pnpm lintpasses)pnpm testpasses)pnpm build)The focused browser test passes with all 15
Linetests. The broader browser suite was stopped after unrelated audio/network, WebGL context-loss, and state timing failures appeared in this environment.Related issues
None.