Repository navigation
FIX: release the converter panel drag styles on unmount - #3631
Open
Manohar Paturi (ManoharPaturi) wants to merge 3 commits into
Open
Manohar Paturi (ManoharPaturi) wants to merge 3 commits into
Manohar Paturi (ManoharPaturi) wants to merge 3 commits into
Conversation
Contributor
|
tiny question, would be great if you could link the issue you mentioned, i'm not seeing it in your PR description! |
Contributor
Author
jbolor21
enabled auto-merge
November 2, 2026 20:10
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3630
The resize drag's cursor and selection lock were only released by the document mouseup handler, which the effect cleanup removes. Unmounting mid drag therefore left
col-resizeover the whole app and text selection disabled until reload. The cleanup now performs the same release whenever a drag is still held.Tests and Documentation
Added a regression test that starts a drag, unmounts the panel while it is held, and asserts both body styles are restored. It fails on main and passes with the change. The full panel suite passes (45 tests) and tsc is clean.
No documentation change needed, so I did not run JupyText.