Repository navigation
5 - FEAT: Latest-response Scoring - #3644
Merged
Richard Lundeen (richlundeen) merged 59 commits intoNov 3, 2026
Merged
Richard Lundeen (richlundeen) merged 59 commits into
Richard Lundeen (richlundeen) merged 59 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Move history into feature routes, add stored ID lookup, and retain the current chat draft. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Preserve discard blocking before resetting the composer and use shared encoded continuation and scenario routes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Keep an explicit not-found page and Home recovery link at unknown URLs. Preserve the last valid chat and dataset views without changing legacy aliases or Registry index behavior. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Prefer the existing retained draft when entering Chat from another view. Keep an already open chat in place so live work is not replaced by an older snapshot. Cover the workflow with the real History table, Chat tabs, composer and reset controls. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Move score matching into Scorer.find_matching_scores so reuse compares the expectation score_async prepares, share chat evaluation and bounded publication between Send and Apply, project the latest-response result, outcome, and canonical response ID from the backend, and keep Apply status in ChatWindow. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Richard Lundeen (richlundeen)
force-pushed
the
richlundeen-chat-scoring
branch
from
October 29, 2026 19:13
8129d80 to
3ecc1bf
Compare
Use shared readiness and completion watchdogs instead of a short scheduling deadline while preserving the concurrent settings edit assertions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Behnam (behnam-o)
approved these changes
Oct 30, 2026
Behnam (behnam-o)
left a comment
Contributor
There was a problem hiding this comment.
[GHCP]: Verdict: APPROVE.
PR 5/10 - Latest-response Scoring. Please address and resolve all 3 numbered inline comments in this review. Approval does not waive any comment.
- [GHCP]: MEDIUM - Conversation-wrapper scorers cannot match their persisted results.
- [GHCP]: MEDIUM - Apply creates judge conversations without attack ownership.
- [GHCP]: MEDIUM - Failed refresh shows an old verdict against a new objective.
Scope: the feature increment 287e94a10c1b0f84e82056ef0cccd37e842de767 -> 3ecc1bfd66979b09526acf4f2af2498ef4c0424c. Static review only; tests, builds, and browser validation were not run.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Keep the messages GET aligned with current attack score, response, outcome, and failure state across successful and failed sends. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Richard Lundeen (richlundeen)
left a comment
Contributor
Author
There was a problem hiding this comment.
Automated review completed. No blocking concerns remain. This review records source coverage; it does not authorize merge.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Persist private participation provenance and validate every participating conversation snapshot before reusing aggregate results. Preserve original same-input anchors for inverter, threshold and fallback roots. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Treat private JSON scalar strings as unknown provenance rather than decoding them into trusted child participation. Cover real persisted string/dict/NULL projection and stale snapshot reuse. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Integrate exact upstream main commit 9cd17cf and preserve its evaluator default regression coverage and refreshed metrics. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Integrate exact upstream a214848 SQL/XSS scorer, regression and synchronized documentation changes without altering prior scorer freshness repairs. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Incorporate exact main 851d40f without changing scorer sources. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Invalidate cached count-only default scores when detection patterns change while retaining custom and exclusion identity behavior. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Richard Lundeen (richlundeen)
marked this pull request as ready for review
November 3, 2026 01:40
Integrate main 0ffa2fc, preserving legacy pruned-conversation history lookup and current chat navigation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Preserve both integration branches and remove the obsolete App mock binding exposed by merging. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Retain independent registry identity rows, the supported adversarial default, and removal of objective defaults. Remove the duplicate identity documentation paragraph introduced by the merge. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Preserve atomic stored-message metadata, shared owned-write cancellation, and chat scoring policy. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Preserve manual chat scoring and content-sensitive regex identities while integrating typed scorer hooks and dependency URL-decoding policy. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Keep equality checks for pattern-only scorers while recognizing default-only preprocessing in merged shell scoring. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Adrian Gavrila (adrian-gavrila)
added a commit
to adrian-gavrila/PyRIT
that referenced
this pull request
Nov 3, 2026
Re-point d43b1bcf9c56 after e7c4a2d9f013 from microsoft#3644, so the chain keeps a single head. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the selected scorer to the latest response in the open conversation from the scorer pane. Reuses valid existing results without changing human scores or future-response scoring.
Changes:
Layer 5/10 | Previous: #3647 | Final: #3648 | Blocked by: #3647
Diff is cumulative until preceding layers merge.
Before (original GUI)
The original scorer pane showed a future-responses explanation and had no Apply action for the latest saved response.
After
Apply scorer is inside the scorer pane after selection. The latest response's result and rationale are shown; earlier responses and other conversations are unchanged.
Applying the same scorer again keeps the existing valid result and rationale. Already scored confirms that no new evaluation ran.
Video
latest-response-scoring-production.webm