Repository navigation
TEST: cover instance registry return types (P311-04) - #3686
Merged
Roman Lutz (romanlutz) merged 3 commits intoOct 31, 2026
Merged
Roman Lutz (romanlutz) merged 3 commits into
Roman Lutz (romanlutz) merged 3 commits into
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
mehmetl33t
force-pushed
the
feat/p311-04-instance-registry-type-checks
branch
from
October 30, 2026 23:51
23d50df to
26bb687
Compare
Roman Lutz (romanlutz)
self-requested a review
October 31, 2026 00:58
10 of 25 tasks
Roman Lutz (romanlutz)
approved these changes
Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assert_typeforDefaultInstanceRegistry[T].get,get_entry, andget_all_instancesintests/unit/registry/test_instance_registry.py.T | None,RegistryEntry[T] | None,list[RegistryEntry[T]]) are preserved for bothDefaultInstanceRegistry[T]and a consumer typed asInstanceRegistry[T].Nonebehavior, and sorted order without modifying runtime code.Part of #3166 (Item P311-04)