Repository navigation
DOC: Fix source links in memory data types page - #3695
Merged
Roman Lutz (romanlutz) merged 6 commits intoNov 1, 2026
Merged
Conversation
Roman Lutz (romanlutz)
approved these changes
Nov 1, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Roman Lutz (romanlutz)
added a commit
to FazeelUsmani/PyRIT
that referenced
this pull request
Nov 1, 2026
Integrate microsoft#3770, microsoft#3697 and microsoft#3695 normally. As requested, retain the upstream deterministic one-node mapping-budget assertion, truncation and exact totals; do not restore the removed wall-clock benchmark. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix five source links in
doc/code/memory/3_memory_data_types.mdthat point to files moved into subpackages:pyrit/models/message_piece.py->pyrit/models/messages/message_piece.pypyrit/models/message.py->pyrit/models/messages/message.pypyrit/models/score.py->pyrit/models/score/score.pypyrit/identifiers/component_identifier.py->pyrit/models/identifiers/component_identifier.pypyrit/identifiers/evaluation_identifier.py->pyrit/models/identifiers/evaluation_identifier.pyAlso prevent this from going unnoticed again: the docs workflow checks the
latestslot, including PR validation, with--site --strict --check-linksbefore rendering. Frozen release builds keep their existing behavior. Localmake docs-buildenables link checking too.Enabling the full check also exposed another stale
Scoresource link, two unresolved Docker provenance references, and an automatically generated HTTP link for crates.io. Correct those and update the contributor build instructions. Keep exact-URL exceptions for the existing Commons image attribution and the crates.io homepage, which reject automated requests. Other URLs on those sites are not excluded.No runtime API changes.
Tests and Documentation
Validated after merging current
main, using Python 3.13 and locked Jupyter Book 2.1.7:uv run --frozen --no-sync pytest -q tests\unit\build_scripts\test_docs_workflow.py tests\unit\build_scripts\test_docs_build_contract.py tests\unit\build_scripts\test_resolve_docs_matrix.py: 71 passed.uv run --frozen --no-sync python -m build_scripts.pydoc2json pyrit --submodules -o doc\_api\pyrit_all.json: passed.uv run --frozen --no-sync python -m build_scripts.gen_api_md: passed, including documentation-structure validation.doc,uv run --frozen --no-sync jupyter-book build --html --strict --check-links: passed, producing the full static HTML book. Existing non-fatal warnings remain.uv run --frozen --no-sync ruff check tests\unit\build_scripts\test_docs_workflow.py tests\unit\build_scripts\test_docs_build_contract.py doc\code\scoring\0_scoring.py doc\scanner\garak.py: passed.uv run --frozen --no-sync ruff format --check tests\unit\build_scripts\test_docs_workflow.py tests\unit\build_scripts\test_docs_build_contract.py doc\code\scoring\0_scoring.py doc\scanner\garak.py: passed.Reproduction: with the original five broken links,
--site --strictsucceeds, but adding--check-linksfails with exactly five link errors. The corrected page passes with--check-links.Updated each affected notebook and its paired percent-format Python file inline. Verified source synchronization and preserved all notebook outputs, metadata, and execution counts. Notebooks were not executed against AI providers; PDF export was not run.