Repository navigation
FIX: Reject mismatched normalizer templates in RoundRobinTarget - #3768
Merged
Roman Lutz (romanlutz) merged 8 commits intoNov 5, 2026
Merged
Roman Lutz (romanlutz) merged 8 commits into
Roman Lutz (romanlutz) merged 8 commits into
Conversation
Vardhman Gupta (Kaap10)
force-pushed
the
fix/round-robin-normalizer-templates-3752
branch
from
November 1, 2026 05:32
4714715 to
221aaf4
Compare
Contributor
Author
|
CI looks good now, up for review! |
Roman Lutz (romanlutz)
left a comment
Roman Lutz (romanlutz)
left a comment
Contributor
There was a problem hiding this comment.
I found two issues in the custom normalizer contract, described below.
Vardhman Gupta (Kaap10)
force-pushed
the
fix/round-robin-normalizer-templates-3752
branch
3 times, most recently
from
November 1, 2026 07:42
97708df to
0f21726
Compare
Contributor
Author
|
Both issues have been addressed in the latest commit Roman Lutz (@romanlutz)! |
…osoft#3752) When initializing RoundRobinTarget with targets that have different JSON-schema normalizer templates, configuration validation did not catch the difference because normalization pipeline serialization only compared class qualnames. As a result, the first target's configuration was adopted and silently replaced the second target's schema instructions. - Preserve MessageListNormalizer(abc.ABC, Generic[T]) without Identifiable to prevent MRO conflicts in (Identifiable, MessageListNormalizer) subclasses - Implement Identifiable in JsonSchemaNormalizer and HistorySquashNormalizer - Implement _build_identifier() in ChatMessageNormalizer (inherits Identifiable) - Update TargetConfiguration._serialize_normalizer() to prioritize Identifiable declared identifiers, honoring custom list normalizers' parameters - Add unit tests verifying RoundRobinTarget rejects custom Identifiable normalizers with mismatched params and accepts identical custom normalizers - Cover fallback and MRO compatibility scenarios with 100% diff coverage
Vardhman Gupta (Kaap10)
force-pushed
the
fix/round-robin-normalizer-templates-3752
branch
from
November 1, 2026 09:37
0f21726 to
d7425d1
Compare
Roman Lutz (romanlutz)
left a comment
Roman Lutz (romanlutz)
left a comment
Contributor
There was a problem hiding this comment.
One remaining issue affects custom normalizers that delegate to another normalizer.
Roman Lutz (romanlutz)
left a comment
Roman Lutz (romanlutz)
left a comment
Contributor
There was a problem hiding this comment.
The child-identity regression is fixed. One CI-blocking test typing issue remains.
Contributor
Author
|
CI Looks good now, Roman Lutz (@romanlutz)! |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Roman Lutz (romanlutz)
approved these changes
Nov 5, 2026
Roman Lutz (romanlutz)
left a comment
Roman Lutz (romanlutz)
left a comment
Contributor
There was a problem hiding this comment.
one more thing I want to fix then it's merge-ready.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3752
When initializing
RoundRobinTargetwith inner targets that have different JSON-schema normalizer templates (configured vianormalizer_overridesonTargetConfiguration), configuration validation did not catch the difference. BecauseTargetConfiguration.as_identifier_params()["normalization_pipeline"]previously only serialized the normalizer class qualname (f"{type(n).__module__}.{type(n).__qualname__}"), targets with distinctschema_instructions_templateparameters appeared identical during consistency checking. As a result, the round-robin target adopted the first target's configuration and silently replaced the second target's schema instructions.Changes:
MessageListNormalizer: Inherits fromIdentifiableand provides defaultas_identifier_params() -> dict[str, Any]: return {}and_build_identifier().JsonSchemaNormalizer: Implementsas_identifier_params()exporting{"schema_instructions_template": self._schema_instructions_template}.ChatMessageNormalizer: Implementsas_identifier_params()exporting{"use_developer_role": ..., "system_message_behavior": ...}.HistorySquashNormalizer: Implementsas_identifier_params()exporting child formatter identifier and message count.TargetConfiguration: Adds_serialize_normalizer()soas_identifier_params()["normalization_pipeline"]reflects normalizer parameters deterministically ({"type": ..., "params": ...}).RoundRobinTarget: Preserves existing validation logic while gaining parameter-level diffing across normalizers.cc Roman Lutz (@romanlutz)
Tests and Documentation
test_init_rejects_mismatched_normalizer_templatesandtest_init_accepts_identical_custom_normalizer_templatesintests/unit/prompt_target/test_round_robin_target.py.test_as_identifier_params_pipeline_distinguishes_normalizer_templatesandtest_as_identifier_params_pipeline_matches_when_normalizer_templates_equalintests/unit/prompt_target/target/test_target_configuration.py.tests/unit/prompt_target/: 32 passedtests/unit/prompt_target/target/: 35 passedtests/unit/message_normalizer/: 90 passedruff check pyrit tests(0 errors)ruff format --check pyrit tests(1820 files formatted)ty check(all checks passed)