Repository navigation
Add noEmit to BuildOrchestrator overrideCompilerOptions - #64759
Open
Elecmonkey (elecmonkey) wants to merge 2 commits into
Open
Elecmonkey (elecmonkey) wants to merge 2 commits into
Elecmonkey (elecmonkey) wants to merge 2 commits into
Conversation
typescript-automation
Bot
added
the
For Uncommitted Bug
Author
|
@microsoft-github-policy-service agree |
Elecmonkey (elecmonkey)
marked this pull request as ready for review
October 13, 2026 03:11
Contributor
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Also fix CreateBuildOrchestratorParams so that build options and compiler option overrides reach the server. The embedded BuildOptions and CompilerOptions had json name tags, so the server expected them nested, but gen-proto ignores tags on embedded fields and generated a flat type, so the client sent them flat and they were silently dropped. Use named fields so the generated type is nested, and have the client build both objects explicitly.
Elecmonkey (elecmonkey)
force-pushed
the
build-orchestrator-noemit
branch
from
October 20, 2026 06:56
d6c94bb to
1328b38
Compare
Martyn Janes (obany)
added a commit
to 3sixtyglobal/framework
that referenced
this pull request
Oct 23, 2026
Add a `tstransform` command and `tsTransform` method to nameof-transformer which compile projects with the native TypeScript compiler, replacing the `nameof` calls as source files are read through a virtual file system. Switch all packages and apps from `tspc` to `tstransform`, move incremental build settings into tsconfig, move vitest cache settings into vitest config, and remove ts-patch. Build orchestrator overrides are sent as both `compilerOptions` and `overrideCompilerOptions` so they apply before and after microsoft/TypeScript#64759 is released.
6 of 11 tasks
Martyn Janes (obany)
added a commit
to 3sixtyglobal/framework
that referenced
this pull request
Oct 23, 2026
Add a `tstransform` command and `tsTransform` method to nameof-transformer which compile projects with the native TypeScript compiler, replacing the `nameof` calls as source files are read through a virtual file system. Switch all packages and apps from `tspc` to `tstransform`, move incremental build settings into tsconfig, move vitest cache settings into vitest config, and remove ts-patch. Build orchestrator overrides are sent as both `compilerOptions` and `overrideCompilerOptions` so they apply before and after microsoft/TypeScript#64759 is released.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #64158: adds
noEmittoOverrideCompilerOptionsforcreateBuildOrchestrator.This also fixes how
createBuildOrchestratorsends its options.CreateBuildOrchestratorParamsembeddedcore.BuildOptionsandcore.CompilerOptionswith JSON name tags, so the server expected them nested underbuildOptionsandcompilerOptions.gen-protoignores tags on embedded fields and generated a flatextends BuildOptions, CompilerOptionstype, so the client sent them flat and the server silently dropped every build option and compiler option override. The params now use namedbuildOptions/compilerOptionsfields, and the client builds both objects explicitly instead of spreading the caller's options.The existing test's
declaration: falseon composite projects now correctly errors (TS6304), so it usesdeclaration: true.