Repository navigation
glasswing mythos fixes - #829
Erica Vellanoweth (ericavella) merged 12 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: ericavella <37354999+ericavella@users.noreply.github.com>
Move credential methods after properties to satisfy StyleCop SA1201. Update Sysbench command expectations and supply missing credential/package mocks. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b9c8c576-c0f3-4629-b9cb-4476aed3d4fd
Build MySQL password arguments from a MySQL-only helper so PostgreSQL credentials cannot flow into command-line logging. Preserve existing MySQL behavior and cover both present and absent PGPASSWORD values. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b9c8c576-c0f3-4629-b9cb-4476aed3d4fd
Retain the existing fixed MySQL hash as a property, without routing command arguments through a password-returning method. Verify that command logging redacts the MySQL value and never includes PostgreSQL environment credentials. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b9c8c576-c0f3-4629-b9cb-4476aed3d4fd
Real-VM validation found that Sysbench rev6 rejects the obsolete --password option for MySQL. Keep credentials off wrapper command lines for both database systems and cover preparation and execution commands. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b9c8c576-c0f3-4629-b9cb-4476aed3d4fd
Protect configuration, population, and workload process logs and failed-process exceptions without changing successful metric input. Cover telemetry, file logs, failures, and overlapping metric values in regression tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b9c8c576-c0f3-4629-b9cb-4476aed3d4fd
Real-VM validationAll six changed profiles have passing functional VM evidence (10 supported profile/platform combinations). VM runs discovered and led to two additional fixes:
Each passing experiment has server/client exit code 0, parsed local traces with no error-level events, no detected test-credential occurrences in scanned logs, and finite positive required workload metrics for every expected scenario. Sysbench OLTP includes all nine scenarios. HammerDB TPCC includes transactions/sec and operations/sec; TPCH includes completed query-set duration/geometric-mean and query-duration metrics. Regression coverage: 14 HammerDB unit tests and 3 functional profile tests passed (4 existing functional cases remain ignored). Final-head Linux/Windows builds, website, CLA, and CodeQL checks all passed. Scope and limitations
|
Move shared credential resolution into PostgreSQLCredentials and update the Sysbench, HammerDB, and PostgreSQL configuration call sites. Preserve file precedence, platform-specific package lookup, sanitized failures, and child process environment handling. Move credential regressions to a dedicated fixture, restoring both component extension files exactly to the PR base. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b9c8c576-c0f3-4629-b9cb-4476aed3d4fd
Credential handling without component-extension changesUpdated in
Moved the unchanged PostgreSQL credential-resolution logic into the database-specific Preserved explicit-file / PGPASSWORD / architecture-specific package precedence, sanitized credential-file failures, child-process-only environment injection, MySQL wrapper compatibility, and HammerDB output redaction. The 12 credential-resolution regression cases now have their own fixture. The solution builds, and all 164 selected credential, component-extension, database action, parser, dependency, and functional regressions pass; 10 existing functional cases remain ignored. All final-head checks passed: Linux and Windows build/tests, CodeQL, website build, and CLA. The earlier VM evidence remains tied to the tested commits listed above. No VMs were rerun for this structural refactor. |
Implement independent credential readers in SysbenchExecutor, HammerDBExecutor, and PostgreSQLServerConfiguration instead of using a shared Core helper or coupling Actions to the PostgreSQL dependency. Preserve file/environment precedence and sanitized failures, with matching regression coverage in each existing component test fixture. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b9c8c576-c0f3-4629-b9cb-4476aed3d4fd
Independent database credential readersUpdated in As requested, Sysbench and HammerDB now each contain their own PostgreSQL credential-reading implementation. PostgreSQL configuration has its own copy in Removed the standalone Preserved explicit-file / PGPASSWORD / architecture-specific package precedence, sanitized failures, child-process-only credential handling, MySQL wrapper compatibility, and HammerDB output redaction. Each of the three existing component test fixtures covers the same 12 credential-reading regression cases. The solution builds and all 188 selected regressions pass; 10 existing functional cases remain ignored. All final-head checks passed: Linux and Windows build/tests, CodeQL, website build, and CLA. The earlier VM evidence remains tied to its recorded commits. No VMs were rerun for this restructuring. |
Remove unused synchronous password getters, the empty Sysbench argument placeholder, and unused HammerDB parameters. Keep credential readers component-local. Replace stale helper-only tests and ignored legacy command expectations with active production-path coverage, and align the PostgreSQL documentation with actual behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b9c8c576-c0f3-4629-b9cb-4476aed3d4fd
|
Cleanup published in a8ae0f4.
Validation: solution compilation and 187 selected tests passed, with zero failures and zero skipped tests. Both changed profiles and the JSON documentation examples parse successfully. No VMs were provisioned or rerun for this cleanup; the earlier VM evidence remains scoped to its documented commits. |
database workloads only