Repository navigation
Remove DTS Autochunking - #839
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Removing public gRPC options breaks source and binary compatibility, while deleting the 5 MiB activity-output test leaves Blob externalization beyond the transport limit without end-to-end coverage.
2 open issues
What changed in this PR
Removes obsolete DTS autochunking configuration and related code, tests, and sample content from the Durable Task SDK, aligning it with the scheduler’s removal of that feature.
Changes:
- Removes public chunk-size options and chunk metadata resets from payload-failure handling.
- Deletes chunking-related tests and updates payload-failure tests to remove chunk-size dependencies.
- Updates documentation and simplifies the large-payload sample.
| File | Description |
|---|---|
test/Worker/Grpc.Tests/GrpcDurableTaskWorkerOptionsTests.cs |
Deletes chunk-size option validation tests. |
test/Grpc.IntegrationTests/LargePayloadTests.cs |
Removes the 5 MiB output externalization test. |
test/Grpc.IntegrationTests/AutochunkTests.cs |
Deletes completion and chunking-related integration tests. |
test/Extensions/AzureBlobPayloads.Tests/OrchestratorPayloadFailureTests.cs |
Removes chunk-size configuration and chunk metadata assertions. |
src/Worker/Grpc/Internal/InternalOptionsExtensions.cs |
Updates callback documentation to omit chunking. |
src/Worker/Grpc/GrpcDurableTaskWorkerOptions.cs |
Removes chunk-size constants and configuration property. |
src/InProcessTestHost/README.md |
Removes guidance about SDK response chunking. |
src/Extensions/AzureBlobPayloads/Interceptors/AzureBlobPayloadsSideCarInterceptor.cs |
Removes chunk metadata resets on permanent payload failures. |
samples/LargePayloadConsoleApp/Program.cs |
Removes the multi-activity chunking scenario and revises comments. |
Review effort: Balanced
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Full-response validation runs before directly registered payload externalizers, causing a 5 MiB activity input to permanently fail the orchestration instead of being externalized.
1 open issue
3 resolved since last review
Review effort: Balanced
wangbill (YunchuWang)
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DTS removed its autochunking support a while back so this PR removes it from this SDK as well.