Repository navigation
fix(view): include mouse fields in macOS touch debug descriptions - #3170
Open
Jason Morse (JasonVMo) wants to merge 1 commit into
Open
Jason Morse (JasonVMo) wants to merge 1 commit into
Jason Morse (JasonVMo) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 33ea5c72-8bbd-448d-aa21-c9b99dd03c96
Author
|
Additional validation: the six independent main fixes (#3170–#3175) were combined at e9667492e9 in an isolated worktree. After regenerating Pods from packages/rn-tester, RNTester-macOS and RNTester for arm64/x86_64 iOS simulators both built successfully. Exact commands, corrected codegen invocation, and limitations are recorded in #3175 (integration validation comment). This is build evidence, not live UI or sanitizer qualification; no PR was merged. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The macOS-only mouse button and modifier fields in
BaseTouchdebug descriptionsare guarded by the misspelled
TARGET_OS_SX. That undefined macro evaluates tozero, so those fields never appear, even in macOS debug builds.
Use the existing
TARGET_OS_OSXguard, matching the payload serialization andthe field declarations, and align the newly enabled entries with their neighbors.
This corrects a fork-only extension; upstream React Native does not have these
macOS debug fields. Event payloads and release builds are unchanged.
Test Plan:
The macOS debug compile below fails before the fix with
'TARGET_OS_SX' is not defined, evaluates to 0 [-Werror,-Wundef]. After thefix, all three compilation checks pass, as do the scoped native formatter and
whitespace checks. Commands were run from the worktree root:
Not run: a full RNTester native build, native unit tests, or runtime logging.
No UI changes or screenshots.